From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, avarab@gmail.com
Subject: [WIP 0/8] Trying to revive GIT_TEST_PROTOCOL_VERSION
Date: Wed, 16 Jan 2019 14:42:08 -0800 [thread overview]
Message-ID: <cover.1547677183.git.jonathantanmy@google.com> (raw)
Ævar, are you planning to revive GIT_TEST_PROTOCOL_VERSION? I have
updated the patchset in light of some new branches that have appeared.
This is on master merged with:
- jk/proto-v2-hidden-refs-fix
- tg/t5570-drop-racy-test
- js/protocol-advertise-multi
- jt/upload-pack-deepen-relative-proto-v2
- jt/fetch-pack-v2
One notable change I made is that I made this envvar determine the
minimum version. So, if GIT_TEST_PROTOCOL_VERSION=1 and the test
explicitly states v2, v2 is used (but if GIT_TEST_PROTOCOL_VERISON=2,
all use v2). I think this reduces the number of false negatives, since
there are quite a few tests that use v2 specific features, and that are
already marked as v2.
I included one genuine bug fix (the last patch) and the rest are either
overspecifications (which I didn't investigate too deeply) or false
negatives. There are still some errors when run with
GIT_TEST_PROTOCOL_VERSION=2 which I don't think are false negatives -
I'll continue to look into them.
Jonathan Tan (8):
tests: define GIT_TEST_PROTOCOL_VERSION
tests: always test fetch of unreachable with v0
t5503: fix overspecification of trace expectation
t5512: compensate for v0 only sending HEAD symrefs
t5700: only run with protocol version 1
tests: fix protocol version for overspecifications
t5552: compensate for v2 filtering ref adv.
remote-curl: in v2, fill credentials if needed
protocol.c | 17 ++++++++--
remote-curl.c | 9 +++++-
t/README | 3 ++
t/t5400-send-pack.sh | 2 +-
t/t5500-fetch-pack.sh | 4 ++-
t/t5503-tagfollow.sh | 2 +-
t/t5512-ls-remote.sh | 18 ++++++++---
t/t5515-fetch-merge-logic.sh | 4 +++
t/t5516-fetch-push.sh | 22 ++++++++++---
t/t5539-fetch-http-shallow.sh | 5 ++-
t/t5541-http-push-smart.sh | 14 +++++++--
t/t5551-http-fetch-smart.sh | 47 +++++++++++++++++++++-------
t/t5552-skipping-fetch-negotiator.sh | 5 ++-
t/t5700-protocol-v1.sh | 3 ++
t/t7406-submodule-update.sh | 5 ++-
15 files changed, 128 insertions(+), 32 deletions(-)
--
2.19.0.271.gfe8321ec05.dirty
next reply other threads:[~2019-01-16 22:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 22:42 Jonathan Tan [this message]
2019-01-16 22:42 ` [WIP 1/8] tests: define GIT_TEST_PROTOCOL_VERSION Jonathan Tan
2019-01-16 22:42 ` [WIP 2/8] tests: always test fetch of unreachable with v0 Jonathan Tan
2019-01-16 22:42 ` [WIP 3/8] t5503: fix overspecification of trace expectation Jonathan Tan
2019-01-16 22:42 ` [WIP 4/8] t5512: compensate for v0 only sending HEAD symrefs Jonathan Tan
2019-01-16 22:42 ` [WIP 5/8] t5700: only run with protocol version 1 Jonathan Tan
2019-01-16 22:42 ` [WIP 6/8] tests: fix protocol version for overspecifications Jonathan Tan
2019-01-16 22:42 ` [WIP 7/8] t5552: compensate for v2 filtering ref adv Jonathan Tan
2019-01-16 22:42 ` [WIP 8/8] remote-curl: in v2, fill credentials if needed Jonathan Tan
2019-01-17 9:31 ` [WIP 0/8] Trying to revive GIT_TEST_PROTOCOL_VERSION Ævar Arnfjörð Bjarmason
2019-01-17 18:37 ` Jonathan Tan
2019-01-17 21:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1547677183.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.