From: Michal Suchanek <msuchanek@suse.de>
To: linux-scsi@vger.kernel.org
Cc: Michal Suchanek <msuchanek@suse.de>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
"Ewan D. Milne" <emilne@redhat.com>,
Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"J. Bruce Fields" <bfields@redhat.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Eric Biggers <ebiggers@google.com>,
Benjamin Coddington <bcodding@redhat.com>,
Hannes Reinecke <hare@suse.com>, Omar Sandoval <osandov@fb.com>,
Ming Lei <ming.lei@redhat.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Bart Van Assche <bvanassche@acm.org>, Tejun Heo <tj@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 0/7] Fix cdrom autoclose
Date: Fri, 25 Oct 2019 13:21:37 +0200 [thread overview]
Message-ID: <cover.1572002144.git.msuchanek@suse.de> (raw)
Hello,
there is cdrom autoclose feature that is supposed to close the tray,
wait for the disc to become ready, and then open the device.
This used to work in ancient times. Then in old times there was a hack
in util-linux which worked around the breakage which probably resulted
from switching to scsi emulation.
Currently util-linux maintainer refuses to merge another hack on the
basis that kernel still has the feature so it should be fixed there.
The code needs not be replicated in every userspace utility like mount
or dd which has no business knowing which devices are CD-roms and where
the autoclose setting is in the kernel.
Link: https://lore.kernel.org/lkml/cover.1513263482.git.msuchanek@suse.de/
Link: https://lore.kernel.org/lkml/cover.1571834862.git.msuchanek@suse.de/
v3:
- change the VMware workaround to use blacklist flag
- use exported function instead of ioctl
Michal Suchanek (7):
cdrom: add poll_event_interruptible
cdrom: factor out common open_for_* code
cdrom: wait for the tray to close
cdrom: export autoclose logic as a separate function
bdev: add open_finish.
scsi: blacklist: add VMware ESXi cdrom - broken tray emulation.
scsi: sr: wait for the medium to become ready
Documentation/filesystems/locking.rst | 2 +
drivers/cdrom/cdrom.c | 192 ++++++++++++++------------
drivers/scsi/scsi_devinfo.c | 15 +-
drivers/scsi/sr.c | 60 ++++++--
fs/block_dev.c | 21 ++-
include/linux/blkdev.h | 1 +
include/linux/cdrom.h | 1 +
include/scsi/scsi_devinfo.h | 7 +-
8 files changed, 191 insertions(+), 108 deletions(-)
--
2.23.0
next reply other threads:[~2019-10-25 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 11:21 Michal Suchanek [this message]
2019-10-25 11:21 ` [PATCH v3 1/7] cdrom: add poll_event_interruptible Michal Suchanek
2019-10-25 11:21 ` [PATCH v3 2/7] cdrom: factor out common open_for_* code Michal Suchanek
2019-10-25 11:21 ` [PATCH v3 3/7] cdrom: wait for the tray to close Michal Suchanek
2019-10-25 11:21 ` [PATCH v3 4/7] cdrom: export autoclose logic as a separate function Michal Suchanek
2019-10-25 11:21 ` [PATCH v3 5/7] bdev: add open_finish Michal Suchanek
2019-11-05 0:17 ` Christoph Hellwig
2019-11-21 10:06 ` Michal Suchánek
2019-10-25 11:21 ` [PATCH v3 6/7] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation Michal Suchanek
2019-10-25 11:21 ` [PATCH v3 7/7] scsi: sr: wait for the medium to become ready Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1572002144.git.msuchanek@suse.de \
--to=msuchanek@suse.de \
--cc=axboe@kernel.dk \
--cc=bcodding@redhat.com \
--cc=bfields@redhat.com \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=ebiggers@google.com \
--cc=emilne@redhat.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab+samsung@kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.