All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: [PATCH v4 0/2] kernel-doc: fix typedef function parser
Date: Tue, 27 Oct 2020 11:20:35 +0100	[thread overview]
Message-ID: <cover.1603792384.git.mchehab+huawei@kernel.org> (raw)

Hi Jon,

This small series contain the latest version of the typedef parsing
fixes that we've been discussing as:

	[PATCH v3 01/56] scripts: kernel-doc: fix typedef parsing

As I said there, at least while discussing it, I opted to split the
patch in two.

The first one changes the regex;
The second one is just a cleanup that splits the 3 arguments into 3
vars.

From my side, I'm not 100% confident if the second patch is
worth or not. 

The advantage of it is that it makes easier to read the regex. 
It also also makes clearer about the differences between
the two typedef regex'es that are used there. 

On the other hand, using a site like regex101.com to
test it is harder, as one needs to copy-and-paste 3 expressions
instead of just one.

So, when appliying, feel free to decide to either:

	-  merge both as-is (two separate patches);
	-  fold them into a single patch;
	- drop the second patch.

Mauro Carvalho Chehab (2):
  scripts: kernel-doc: fix typedef parsing
  scripts: kernel-doc: split typedef complex regex

 scripts/kernel-doc | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

-- 
2.26.2



             reply	other threads:[~2020-10-27 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 10:20 Mauro Carvalho Chehab [this message]
2020-10-27 10:20 ` [PATCH v4 1/2] scripts: kernel-doc: fix typedef parsing Mauro Carvalho Chehab
2020-10-27 10:20 ` [PATCH v4 2/2] scripts: kernel-doc: split typedef complex regex Mauro Carvalho Chehab
2020-10-28 17:18 ` [PATCH v4 0/2] kernel-doc: fix typedef function parser Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1603792384.git.mchehab+huawei@kernel.org \
    --to=mchehab+huawei@kernel.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.