All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: [PATCH 0/2] Fix some issues at scripts/sphinx-pre-install
Date: Tue, 25 May 2021 15:27:26 +0200	[thread overview]
Message-ID: <cover.1621949137.git.mchehab+huawei@kernel.org> (raw)

Currently, when using with --no-virtualenv, the script doesn't behave well,
as it prints both instructions to install Sphinx via distribution's package
manager and via pip.

Address it.

While here, rework the logic which recommends Sphinx install, by
splitting it into three parts and making easier to maintain it, as
there are too much complexity there. Splitting the Sphinx part
of the logic on 3 separate functions allow to detect if the venv/virtualenv
python packages are needed or not, and helps to have a cleaner
logic.

Mauro Carvalho Chehab (2):
  scripts: sphinx-pre-install: rework the sphinx install logic
  scripts: sphinx-pre-install: fix the need of virtenv packages

 scripts/sphinx-pre-install | 262 +++++++++++++++++++++++++------------
 1 file changed, 180 insertions(+), 82 deletions(-)

-- 
2.31.1



             reply	other threads:[~2021-05-25 13:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 13:27 Mauro Carvalho Chehab [this message]
2021-05-25 13:27 ` [PATCH 1/2] scripts: sphinx-pre-install: rework the sphinx install logic Mauro Carvalho Chehab
2021-05-25 13:27 ` [PATCH 2/2] scripts: sphinx-pre-install: fix the need of virtenv packages Mauro Carvalho Chehab
2021-06-01 22:29 ` [PATCH 0/2] Fix some issues at scripts/sphinx-pre-install Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1621949137.git.mchehab+huawei@kernel.org \
    --to=mchehab+huawei@kernel.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.