From: Asutosh Das <quic_asutoshd@quicinc.com>
To: <quic_cang@quicinc.com>, <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>
Cc: <quic_nguyenb@quicinc.com>, <quic_xiaosenh@quicinc.com>,
<stanley.chu@mediatek.com>, <eddie.huang@mediatek.com>,
<daejun7.park@samsung.com>, <bvanassche@acm.org>,
<avri.altman@wdc.com>, <mani@kernel.org>, <beanhuo@micron.com>,
Asutosh Das <quic_asutoshd@quicinc.com>,
<linux-arm-msm@vger.kernel.org>
Subject: [PATCH v4 00/16] Add Multi Circular Queue Support
Date: Wed, 9 Nov 2022 11:41:25 -0800 [thread overview]
Message-ID: <cover.1668022680.git.quic_asutoshd@quicinc.com> (raw)
UFS Multi-Circular Queue (MCQ) has been added in UFSHCI v4.0 to improve storage performance.
The implementation uses the shared tagging mechanism so that tags are shared
among the hardware queues. The number of hardware queues is configurable.
This series doesn't include the ESI implementation for completion handling.
This implementation has been verified by booting on a Qualcomm platform.
During testing, all low power modes were disabled and it was in HS-G1 mode.
Please take a look and let us know your thoughts.
v3 -> v4:
- Added a kernel module parameter to disable MCQ mode
- Added Bart's reviewed-by tag for some patches
- Addressed Bart's comments
v2 -> v3:
- Split ufshcd_config_mcq() into ufshcd_alloc_mcq() and ufshcd_config_mcq()
- Use devm_kzalloc() in ufshcd_mcq_init()
- Free memory and resource allocation on error paths
- Corrected typos in code comments
v1 -> v2:
- Added a non MCQ related change to use a function to extrace ufs extended
feature
- Addressed Mani's comments
- Addressed Bart's comments
v1:
- Split the changes
- Addressed Bart's comments
- Addressed Bean's comments
* RFC versions:
v2 -> v3:
- Split the changes based on functionality
- Addressed queue configuration issues
- Faster SQE tail pointer increments
- Addressed comments from Bart and Manivannan
v1 -> v2:
- Enabled host_tagset
- Added queue num configuration support
- Added one more vops to allow vendor provide the wanted MAC
- Determine nutrs and can_queue by considering both MAC, bqueuedepth and EXT_IID support
- Postponed MCQ initialization and scsi_add_host() to async probe
- Used (EXT_IID, Task Tag) tuple to support up to 4096 tasks (theoretically)
Asutosh Das (16):
ufs: core: Optimize duplicate code to read extended feature
ufs: core: Probe for ext_iid support
ufs: core: Introduce Multi-circular queue capability
ufs: core: Defer adding host to scsi if mcq is supported
ufs: core: mcq: Add Multi Circular Queue support
ufs: core: mcq: Configure resource regions
ufs: core: mcq: Calculate queue depth
ufs: core: mcq: Allocate memory for mcq mode
ufs: core: mcq: Configure operation and runtime interface
ufs: core: mcq: Use shared tags for MCQ mode
ufs: core: Prepare ufshcd_send_command for mcq
ufs: core: mcq: Find hardware queue to queue request
ufs: core: Prepare for completion in mcq
ufs: mcq: Add completion support of a cqe
ufs: core: mcq: Add completion support in poll
ufs: core: mcq: Enable Multi Circular Queue
drivers/ufs/core/Makefile | 2 +-
drivers/ufs/core/ufs-mcq.c | 494 +++++++++++++++++++++++++++++++++++++++++
drivers/ufs/core/ufshcd-priv.h | 84 ++++++-
drivers/ufs/core/ufshcd.c | 381 +++++++++++++++++++++++++------
drivers/ufs/host/ufs-qcom.c | 48 ++++
drivers/ufs/host/ufs-qcom.h | 4 +
include/ufs/ufs.h | 6 +
include/ufs/ufshcd.h | 125 +++++++++++
include/ufs/ufshci.h | 63 ++++++
9 files changed, 1140 insertions(+), 67 deletions(-)
create mode 100644 drivers/ufs/core/ufs-mcq.c
--
2.7.4
next reply other threads:[~2022-11-09 19:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 19:41 Asutosh Das [this message]
2022-11-09 19:41 ` [PATCH v4 01/16] ufs: core: Optimize duplicate code to read extended feature Asutosh Das
2022-11-09 20:54 ` Bart Van Assche
2022-11-09 19:41 ` [PATCH v4 02/16] ufs: core: Probe for ext_iid support Asutosh Das
2022-11-09 20:56 ` Bart Van Assche
2022-11-10 10:47 ` Avri Altman
2022-11-09 19:41 ` [PATCH v4 03/16] ufs: core: Introduce Multi-circular queue capability Asutosh Das
2022-11-09 20:59 ` Bart Van Assche
2022-11-09 19:41 ` [PATCH v4 04/16] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-11-09 19:41 ` [PATCH v4 05/16] ufs: core: mcq: Add Multi Circular Queue support Asutosh Das
2022-11-09 21:16 ` Bart Van Assche
2022-11-09 19:41 ` [PATCH v4 06/16] ufs: core: mcq: Configure resource regions Asutosh Das
2022-11-09 21:21 ` Bart Van Assche
2022-11-09 19:41 ` [PATCH v4 07/16] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-11-09 21:28 ` Bart Van Assche
2022-11-09 19:41 ` [PATCH v4 08/16] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-11-09 21:36 ` Bart Van Assche
2022-11-09 19:41 ` [PATCH v4 09/16] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-11-09 21:39 ` Bart Van Assche
2022-11-09 19:41 ` [PATCH v4 10/16] ufs: core: mcq: Use shared tags for MCQ mode Asutosh Das
2022-11-09 19:41 ` [PATCH v4 11/16] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-11-09 19:41 ` [PATCH v4 12/16] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-11-09 19:41 ` [PATCH v4 13/16] ufs: core: Prepare for completion in mcq Asutosh Das
2022-11-09 19:41 ` [PATCH v4 14/16] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-11-11 19:54 ` kernel test robot
2022-11-11 20:15 ` kernel test robot
2022-11-09 19:41 ` [PATCH v4 15/16] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-11-09 19:41 ` [PATCH v4 16/16] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1668022680.git.quic_asutoshd@quicinc.com \
--to=quic_asutoshd@quicinc.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=eddie.huang@mediatek.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_xiaosenh@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.