cryptsetup.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Jasper Surmont <surmontjasper@gmail.com>
To: cryptsetup@lists.linux.dev
Subject: dm-verity design question
Date: Tue, 12 Apr 2022 12:38:27 +0300	[thread overview]
Message-ID: <CAH4tiUts6MVKNv6RVQhPD3fSGruZo=iYpeY1XrbMs-rUx7TLFw@mail.gmail.com> (raw)

Hey,

After going through the dm-verity source code for a while I think I
kind of figured out the general design; on a read:
1. Multiple possible problems get checked like alignment, out of range
etc. Also variables get set based on the request
2. The request is prefetched to the cache
3. The actual integrity check is done when the bio ends (bi_end_io
points to verity_end_io which submits the work to verify digest etc

If this is correct, I have 2 questions:
1. What is the main benefit of prefetching here? We know the remapped
request is going to be executed very soon, so I don't really see why
we prefetch.
2. In verity_end_io(...), we only submit the work to verify the digest
if FEC is enabled. Why? Can't we check integrity without using FEC?

I hope my questions are clear.

Thanks a lot!

Sincerely, Jasper Surmont

             reply	other threads:[~2022-04-12  9:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12  9:38 Jasper Surmont [this message]
2022-04-12  9:47 ` dm-verity design question Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH4tiUts6MVKNv6RVQhPD3fSGruZo=iYpeY1XrbMs-rUx7TLFw@mail.gmail.com' \
    --to=surmontjasper@gmail.com \
    --cc=cryptsetup@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).