From: Reinette Chatre <reinette.chatre@intel.com>
To: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "Luck, Tony" <tony.luck@intel.com>,
"babu.moger@amd.com" <babu.moger@amd.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V1 01/13] selftests/resctrl: Fix feature detection
Date: Mon, 9 Mar 2020 15:33:57 -0700 [thread overview]
Message-ID: <d0409729-b546-f0b9-4944-cbe5c9a74f76@intel.com> (raw)
In-Reply-To: <FFF73D592F13FD46B8700F0A279B802F57307F89@ORSMSX114.amr.corp.intel.com>
Hi Sai,
On 3/9/2020 3:22 PM, Prakhya, Sai Praneeth wrote:
> Hi Reinette,
>
>> -----Original Message-----
>> From: Reinette Chatre <reinette.chatre@intel.com>
>> Sent: Monday, March 9, 2020 2:45 PM
>> On 3/6/2020 7:40 PM, Sai Praneeth Prakhya wrote:
[SNIP]
>> Please note that this is only a partial fix. The current feature detection relies on
>> the feature flags found in /proc/cpuinfo. Quirks and kernel boot parameters are
>> not taken into account. This fix only addresses the parsing of feature flags. If a
>> feature has been disabled via kernel boot parameter or quirk then the resctrl
>> tests would still attempt to run the test for it.
>
> That's a good point and makes sense to me. I think we could fix it in two ways
> 1. grep for strings in dmesg but that will still leave ambiguity in deciding b/w mbm and cqm because kernel prints "resctrl: L3 monitoring detected" for both the features
> 2. Check in "info" directory
> a. For cat_l3, we could search for info/L3
> b. For mba, we could search for info/MB
> c. For cqm and mbm, we could search for specified string in info/L3_MON/mon_features
>
> I think option 2 might be better because it can handle all cases, please let me know what you think.
I agree. For the reasons you mention and also that (1) may not be
possible if the loglevel prevents those lines from being printed.
Reinette
next prev parent reply other threads:[~2020-03-09 22:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 3:40 [PATCH V1 00/13] Miscellaneous fixes for resctrl selftests Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 01/13] selftests/resctrl: Fix feature detection Sai Praneeth Prakhya
2020-03-09 21:44 ` Reinette Chatre
2020-03-09 22:22 ` Prakhya, Sai Praneeth
2020-03-09 22:33 ` Reinette Chatre [this message]
2020-03-09 22:51 ` Prakhya, Sai Praneeth
2020-03-11 18:06 ` Reinette Chatre
2020-03-11 18:22 ` Sai Praneeth Prakhya
2020-03-11 18:45 ` Reinette Chatre
2020-03-11 18:54 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 02/13] selftests/resctrl: Fix typo Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 03/13] selftests/resctrl: Fix typo in help text Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 04/13] selftests/resctrl: Ensure sibling CPU is not same as original CPU Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 05/13] selftests/resctrl: Fix missing options "-n" and "-p" Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 06/13] selftests/resctrl: Fix MBA/MBM results reporting format Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 07/13] selftests/resctrl: Don't use variable argument list for setup function Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 08/13] selftests/resctrl: Fix typos Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 09/13] selftests/resctrl: Modularize fill_buf for new CAT test case Sai Praneeth Prakhya
2020-03-10 21:59 ` Reinette Chatre
2020-03-11 1:04 ` Sai Praneeth Prakhya
2020-03-11 15:44 ` Reinette Chatre
2020-03-11 17:45 ` Sai Praneeth Prakhya
2020-03-11 18:10 ` Reinette Chatre
2020-03-11 18:14 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 10/13] selftests/resctrl: Change Cache Allocation Technology (CAT) test Sai Praneeth Prakhya
2020-03-10 22:14 ` Reinette Chatre
2020-03-11 1:59 ` Sai Praneeth Prakhya
2020-03-11 17:03 ` Reinette Chatre
2020-03-11 19:14 ` Sai Praneeth Prakhya
2020-03-11 20:22 ` Reinette Chatre
2020-03-11 20:55 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 11/13] selftests/resctrl: Change Cache Quality Monitoring (CQM) test Sai Praneeth Prakhya
2020-03-10 22:18 ` Reinette Chatre
2020-03-11 2:46 ` Sai Praneeth Prakhya
2020-03-11 17:19 ` Reinette Chatre
2020-03-11 17:33 ` Sai Praneeth Prakhya
2020-03-11 18:03 ` Reinette Chatre
2020-03-11 18:07 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 12/13] selftests/resctrl: Dynamically select buffer size for CAT test Sai Praneeth Prakhya
2020-03-10 22:19 ` Reinette Chatre
2020-03-11 2:52 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 13/13] selftests/resctrl: Cleanup fill_buff after changing " Sai Praneeth Prakhya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0409729-b546-f0b9-4944-cbe5c9a74f76@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.