From: Jimmy Assarsson <jimmyassarsson@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can <linux-can@vger.kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Wolfgang Grandegger <wg@grandegger.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH v2 1/5] can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)
Date: Tue, 9 Mar 2021 09:30:19 +0100 [thread overview]
Message-ID: <d0761226-9509-18e1-b36b-ba6318eccb3f@gmail.com> (raw)
In-Reply-To: <20210224073140.vinoopn5zoxvyuq3@pengutronix.de>
On 2021-02-24 08:31, Marc Kleine-Budde wrote:
> On 24.02.2021 09:20:04, Vincent Mailhol wrote:
>> --- a/include/linux/can/bittiming.h
>> +++ b/include/linux/can/bittiming.h
>> @@ -1,5 +1,6 @@
>> /* SPDX-License-Identifier: GPL-2.0-only */
>> /* Copyright (c) 2020 Pengutronix, Marc Kleine-Budde <kernel@pengutronix.de>
>> + * Copyright (c) 2021 Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>> */
>>
>> #ifndef _CAN_BITTIMING_H
>> @@ -10,6 +11,70 @@
>>
>> #define CAN_SYNC_SEG 1
>>
>> +/*
>> + * struct can_tdc - CAN FD Transmission Delay Compensation parameters
>> + *
>> + * At high bit rates, the propagation delay from the TX pin to the RX
>> + * pin of the transceiver causes measurement errors: the sample point
>> + * on the RX pin might occur on the previous bit.
>> + *
>> + * To solve this issue, ISO 11898-1 introduces in section 11.3.3
>> + * "Transmitter delay compensation" a SSP (Secondary Sample Point)
>> + * equal to the distance, in time quanta, from the start of the bit
>> + * time on the TX pin to the actual measurement on the RX pin.
>> + *
>> + * This structure contains the parameters to calculate that SSP.
>> + *
>> + * @tdcv: Transmitter Delay Compensation Value. Distance, in time
>> + * quanta, from when the bit is sent on the TX pin to when it is
>> + * received on the RX pin of the transmitter. Possible options:
>> + *
>> + * O: automatic mode. The controller dynamically measure @tdcv
>> + * for each transmited CAN FD frame.
> ^^^
> transmitted
>
> Fixed while applying to linux-can-next/testing. As net-next ist still
> closed, there is still some time to the next pull request and I'll
> squash patches if needed.
Hi Marc,
Can't find this in linux-can-next/testing
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=testing
Regards,
jimmy
next prev parent reply other threads:[~2021-03-09 8:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 0:20 [PATCH v2 0/5] Introducing new CAN FD bittiming parameters: Transmission Delay Compensation (TDC) Vincent Mailhol
2021-02-24 0:20 ` [PATCH v2 1/5] can: add new CAN FD bittiming parameters: Transmitter " Vincent Mailhol
2021-02-24 7:31 ` Marc Kleine-Budde
2021-03-09 8:30 ` Jimmy Assarsson [this message]
2021-03-09 8:34 ` Marc Kleine-Budde
2021-03-09 9:09 ` Jimmy Assarsson
2021-06-16 9:54 ` Marc Kleine-Budde
2021-06-16 12:44 ` Vincent MAILHOL
2021-02-24 0:20 ` [PATCH v2 2/5] can: dev: reorder struct can_priv members for better packing Vincent Mailhol
2021-02-24 0:20 ` [PATCH v2 3/5] can: netlink: move '=' operators back to previous line (checkpatch fix) Vincent Mailhol
2021-02-24 0:20 ` [PATCH v2 4/5] can: add netlink interface for CAN-FD Transmitter Delay Compensation (TDC) Vincent Mailhol
2021-03-09 13:16 ` Vincent MAILHOL
2021-03-09 13:19 ` Marc Kleine-Budde
2021-03-15 15:59 ` Marc Kleine-Budde
2021-03-16 15:16 ` Vincent MAILHOL
2021-03-16 15:29 ` Marc Kleine-Budde
2021-04-05 2:29 ` Vincent MAILHOL
2021-04-07 8:15 ` Marc Kleine-Budde
2021-02-24 0:20 ` [PATCH v2 5/5] can: bittiming: add calculation for CAN FD " Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0761226-9509-18e1-b36b-ba6318eccb3f@gmail.com \
--to=jimmyassarsson@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.