Re: [kvm-unit-tests PATCH v2 2/3] lib: s390x: sclp: Extend feature probing

From: Janosch Frank <frankja@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: kvm@vger.kernel.org, david@redhat.com,
	linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
	thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 2/3] lib: s390x: sclp: Extend feature probing
Date: Wed, 19 May 2021 12:43:52 +0200	[thread overview]
Message-ID: <d0b1ee02-c956-e334-467a-7abb964382b2@linux.ibm.com> (raw)
In-Reply-To: <20210519121711.22ed02ba.cohuck@redhat.com>

On 5/19/21 12:17 PM, Cornelia Huck wrote:
> On Wed, 19 May 2021 08:26:47 +0000
> Janosch Frank <frankja@linux.ibm.com> wrote:
> 
>> Lets grab more of the feature bits from SCLP read info so we can use
> 
> s/Lets/Let's/ :)

Sigh

> 
>> them in the cpumodel tests.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>> ---
>>  lib/s390x/sclp.c | 20 ++++++++++++++++++++
>>  lib/s390x/sclp.h | 38 +++++++++++++++++++++++++++++++++++---
>>  2 files changed, 55 insertions(+), 3 deletions(-)
> 
> (...)
> 
> Maybe add
> 
> /* bit number within a certain byte */

Sure

> 
>> +#define SCLP_FEAT_85_BIT_GSLS		7
>> +#define SCLP_FEAT_98_BIT_KSS		0
>> +#define SCLP_FEAT_116_BIT_64BSCAO	7
>> +#define SCLP_FEAT_116_BIT_CMMA		6
>> +#define SCLP_FEAT_116_BIT_ESCA		3
>> +#define SCLP_FEAT_117_BIT_PFMFI		6
>> +#define SCLP_FEAT_117_BIT_IBS		5
>> +
>>  typedef struct ReadInfo {
>>  	SCCBHeader h;
>>  	uint16_t rnmax;
> 
> Acked-by: Cornelia Huck <cohuck@redhat.com>
> 

Thanks!