From: Guenter Roeck <linux@roeck-us.net>
To: Abdel Alkuor <alkuor@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 2/2] hwmon: (lm75) Add AMS AS6200 temperature sensor
Date: Sun, 31 Dec 2023 10:20:11 -0800 [thread overview]
Message-ID: <d25238a7-0193-4025-950e-086ae2ce853b@roeck-us.net> (raw)
In-Reply-To: <ca786cac-aa83-4795-8b91-ee85b07bdcfa@roeck-us.net>
On Sun, Dec 31, 2023 at 10:17:05AM -0800, Guenter Roeck wrote:
> On Sat, Dec 23, 2023 at 11:21:59AM -0500, Abdel Alkuor wrote:
> > as6200 is a temperature sensor with 0.0625°C resolution and a
> > range between -40°C to 125°C.
> >
> > By default, the driver configures as6200 as following:
> > - Converstion rate: 8 Hz
> > - Conversion mode: continuous
> > - Consecutive fault counts: 4 samples
> > - Alert state: high polarity
> > - Alert mode: comparator mode
> >
> > Interrupt is supported for the alert pin.
> >
> > Datasheet: https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf
> > Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
>
> Applied. Side note below.
>
> > + Datasheet: Publicly available at the AMS website
> > +
> > + https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf
>
> Apparently checkpatch doesn't like this way of pointing to a datasheet anymore
> and reacts with a warning, demanding the use of Link: or similar.
> I don't think this is appropriate, so I guess we see the first instance of
> to-be-ignored checkpatch warnings ins the hwmon subsystem.
>
Ah, no, this was a tag in the commit message, which is indeeed inappropriate.
I dropped it from the commit.
Guenter
next prev parent reply other threads:[~2023-12-31 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 16:21 [PATCH v4 1/2] dt-bindings: hwmon: (lm75) Add AMS AS6200 temperature sensor Abdel Alkuor
2023-12-23 16:21 ` [PATCH v4 2/2] " Abdel Alkuor
2023-12-31 18:17 ` Guenter Roeck
2023-12-31 18:20 ` Guenter Roeck [this message]
2023-12-24 9:32 ` [PATCH v4 1/2] dt-bindings: " Krzysztof Kozlowski
2023-12-31 18:12 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d25238a7-0193-4025-950e-086ae2ce853b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alkuor@gmail.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.