From: Vineeth Vijayan <vneethv@linux.ibm.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: kernel@pengutronix.de, Cornelia Huck <cohuck@redhat.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] s390/ccwgroup: Drop if with an always false condition
Date: Wed, 7 Jul 2021 13:15:32 +0200 [thread overview]
Message-ID: <d2a0875f-f6e5-e3e7-82d6-032bc1c431f4@linux.ibm.com> (raw)
In-Reply-To: <20210706154803.1631813-3-u.kleine-koenig@pengutronix.de>
Thank you. Looks good to me.
Heiko/Vasily will pick this up and will be part of the next s390-tree
patchset.
Also,
Acked-by: Vineeth Vijayan <vneethv@linux.ibm.com>
On 7/6/21 5:48 PM, Uwe Kleine-König wrote:
> The driver core only calls a bus remove callback when there is a driver.
> So dev->driver is never NULL and the check can safely be removed.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/s390/cio/ccwgroup.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
> index 9748165e08e9..a6aeab1ea0ae 100644
> --- a/drivers/s390/cio/ccwgroup.c
> +++ b/drivers/s390/cio/ccwgroup.c
> @@ -444,8 +444,6 @@ static int ccwgroup_remove(struct device *dev)
> struct ccwgroup_device *gdev = to_ccwgroupdev(dev);
> struct ccwgroup_driver *gdrv = to_ccwgroupdrv(dev->driver);
>
> - if (!dev->driver)
> - return 0;
> if (gdrv->remove)
> gdrv->remove(gdev);
>
next prev parent reply other threads:[~2021-07-07 11:15 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 15:47 [PATCH v2 0/4] bus: Make remove callback return void Uwe Kleine-König
2021-07-06 15:47 ` Uwe Kleine-König
2021-07-06 15:47 ` Uwe Kleine-König
2021-07-06 15:47 ` Uwe Kleine-König
2021-07-06 15:48 ` [PATCH v2 1/4] s390/cio: Make struct css_driver::remove " Uwe Kleine-König
2021-07-06 15:58 ` Cornelia Huck
2021-07-06 16:05 ` Uwe Kleine-König
2021-07-07 11:28 ` Vineeth Vijayan
2021-07-07 14:34 ` Uwe Kleine-König
2021-07-12 12:13 ` Heiko Carstens
2021-07-06 15:48 ` [PATCH v2 2/4] s390/ccwgroup: Drop if with an always false condition Uwe Kleine-König
2021-07-06 16:04 ` Cornelia Huck
2021-07-07 11:15 ` Vineeth Vijayan [this message]
2021-07-06 15:48 ` [PATCH v2 3/4] s390/scm: Make struct scm_driver::remove return void Uwe Kleine-König
2021-07-06 16:05 ` Cornelia Huck
2021-07-07 11:32 ` Vineeth Vijayan
2021-07-06 15:48 ` [PATCH v2 4/4] bus: Make remove callback " Uwe Kleine-König
2021-07-06 15:48 ` Uwe Kleine-König
2021-07-06 15:48 ` Uwe Kleine-König
2021-07-06 15:48 ` Uwe Kleine-König
2021-07-06 16:09 ` Cornelia Huck
2021-07-06 16:09 ` Cornelia Huck
2021-07-06 16:09 ` Cornelia Huck
2021-07-06 16:09 ` Cornelia Huck
2021-07-06 16:09 ` Cornelia Huck
2021-07-06 16:44 ` Rafael J. Wysocki
2021-07-06 16:44 ` Rafael J. Wysocki
2021-07-06 16:44 ` Rafael J. Wysocki
2021-07-06 16:44 ` Rafael J. Wysocki
2021-07-06 16:44 ` Rafael J. Wysocki
2021-07-06 18:08 ` Bjorn Andersson
2021-07-06 18:08 ` Bjorn Andersson
2021-07-06 18:08 ` Bjorn Andersson
2021-07-06 18:08 ` Bjorn Andersson
2021-07-06 18:08 ` Bjorn Andersson
2021-07-06 18:43 ` Uwe Kleine-König
2021-07-06 18:43 ` Uwe Kleine-König
2021-07-06 18:43 ` Uwe Kleine-König
2021-07-06 18:43 ` Uwe Kleine-König
2021-07-06 20:43 ` Bjorn Andersson
2021-07-06 20:43 ` Bjorn Andersson
2021-07-06 20:43 ` Bjorn Andersson
2021-07-06 20:43 ` Bjorn Andersson
2021-07-06 20:43 ` Bjorn Andersson
2021-07-06 18:15 ` Srinivas Pandruvada
2021-07-06 18:15 ` Srinivas Pandruvada
2021-07-06 18:15 ` Srinivas Pandruvada
2021-07-06 18:15 ` Srinivas Pandruvada
2021-07-06 18:32 ` Uwe Kleine-König
2021-07-06 18:32 ` Uwe Kleine-König
2021-07-06 18:32 ` Uwe Kleine-König
2021-07-06 18:32 ` Uwe Kleine-König
2021-07-06 18:51 ` Dan Williams
2021-07-06 18:51 ` Dan Williams
2021-07-06 18:51 ` Dan Williams
2021-07-06 18:51 ` Dan Williams
2021-07-06 18:51 ` Dan Williams
2021-07-06 21:37 ` William Breathitt Gray
2021-07-06 21:37 ` William Breathitt Gray
2021-07-06 21:37 ` William Breathitt Gray
2021-07-06 21:37 ` William Breathitt Gray
2021-07-07 5:57 ` Stefan Richter
2021-07-07 14:24 ` Benjamin Tissoires
2021-07-07 14:24 ` Benjamin Tissoires
2021-07-07 14:24 ` Benjamin Tissoires
2021-07-07 14:24 ` Benjamin Tissoires
2021-07-07 21:51 ` Thorsten Scherer
2021-07-07 21:51 ` Thorsten Scherer
2021-07-07 21:51 ` Thorsten Scherer
2021-07-07 21:51 ` Thorsten Scherer
2021-07-07 21:51 ` Thorsten Scherer
2021-07-08 12:41 ` Ulf Hansson
2021-07-08 12:41 ` Ulf Hansson
2021-07-08 12:41 ` Ulf Hansson
2021-07-08 12:41 ` Ulf Hansson
2021-07-15 12:41 ` Wei Liu
2021-07-15 13:02 ` Thomas Bogendoerfer
2021-07-15 13:02 ` Thomas Bogendoerfer
2021-07-15 13:02 ` Thomas Bogendoerfer
2021-07-15 13:02 ` Thomas Bogendoerfer
2021-07-15 13:02 ` Thomas Bogendoerfer
2021-07-08 2:08 ` [PATCH v2 0/4] " Sven Van Asbroeck
2021-07-08 2:08 ` Sven Van Asbroeck
2021-07-08 2:08 ` Sven Van Asbroeck
2021-07-08 2:08 ` Sven Van Asbroeck
2021-07-08 5:38 ` Uwe Kleine-König
2021-07-08 5:38 ` Uwe Kleine-König
2021-07-08 5:38 ` Uwe Kleine-König
2021-07-08 5:38 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2a0875f-f6e5-e3e7-82d6-032bc1c431f4@linux.ibm.com \
--to=vneethv@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.