From: Harry Wentland <hwentlan@amd.com>
To: "Francis, David" <David.Francis@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v8 2/6] drm/dp_mst: Parse FEC capability on MST ports
Date: Mon, 26 Aug 2019 18:36:16 +0000 [thread overview]
Message-ID: <d3aaa435-cc80-ef71-cd6e-3183590defe1@amd.com> (raw)
In-Reply-To: <20190826180507.17802-3-David.Francis@amd.com>
On 2019-08-26 2:05 p.m., David Francis wrote:
> As of DP1.4, ENUM_PATH_RESOURCES returns a bit indicating
> if FEC can be supported up to that point in the MST network.
>
> The bit is the first byte of the ENUM_PATH_RESOURCES ack reply,
> bottom-most bit (refer to section 2.11.9.4 of DP standard,
> v1.4)
>
> That value is needed for FEC and DSC support
>
> Store it on drm_dp_mst_port
>
> Signed-off-by: David Francis <David.Francis@amd.com>
> Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++
> include/drm/drm_dp_mst_helper.h | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 3e7b7553cf4d..9f3604355705 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -553,6 +553,7 @@ static bool drm_dp_sideband_parse_enum_path_resources_ack(struct drm_dp_sideband
> {
> int idx = 1;
> repmsg->u.path_resources.port_number = (raw->msg[idx] >> 4) & 0xf;
> + repmsg->u.path_resources.fec_capable = raw->msg[idx] & 0x1;
> idx++;
> if (idx > raw->curlen)
> goto fail_len;
> @@ -2183,6 +2184,7 @@ static int drm_dp_send_enum_path_resources(struct drm_dp_mst_topology_mgr *mgr,
> DRM_DEBUG_KMS("enum path resources %d: %d %d\n", txmsg->reply.u.path_resources.port_number, txmsg->reply.u.path_resources.full_payload_bw_number,
> txmsg->reply.u.path_resources.avail_payload_bw_number);
> port->available_pbn = txmsg->reply.u.path_resources.avail_payload_bw_number;
> + port->fec_capable = txmsg->reply.u.path_resources.fec_capable;
> }
> }
>
> diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h
> index 9116b2c95239..f113ae04fa88 100644
> --- a/include/drm/drm_dp_mst_helper.h
> +++ b/include/drm/drm_dp_mst_helper.h
> @@ -108,6 +108,8 @@ struct drm_dp_mst_port {
> * audio-capable.
> */
> bool has_audio;
> +
> + bool fec_capable;
> };
>
> /**
> @@ -312,6 +314,7 @@ struct drm_dp_port_number_req {
>
> struct drm_dp_enum_path_resources_ack_reply {
> u8 port_number;
> + bool fec_capable;
> u16 full_payload_bw_number;
> u16 avail_payload_bw_number;
> };
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-26 18:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 18:05 [PATCH v8 0/6] DSC MST support in DRM David Francis
2019-08-26 18:05 ` [PATCH v8 1/6] drm/dp_mst: Add PBN calculation for DSC modes David Francis
2019-08-26 18:36 ` Harry Wentland
2019-08-26 18:05 ` [PATCH v8 2/6] drm/dp_mst: Parse FEC capability on MST ports David Francis
2019-08-26 18:36 ` Harry Wentland [this message]
2019-08-26 18:05 ` [PATCH v8 3/6] drm/dp_mst: Add MST support to DP DPCD R/W functions David Francis
2019-08-26 18:41 ` Harry Wentland
2019-08-26 18:05 ` [PATCH v8 4/6] drm/dp_mst: Fill branch->num_ports David Francis
2019-08-26 18:44 ` Harry Wentland
2019-08-26 18:05 ` [PATCH v8 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs David Francis
2019-08-26 19:05 ` Harry Wentland
2019-08-26 19:14 ` Francis, David
2019-08-26 20:52 ` Harry Wentland
2019-08-27 7:21 ` Jani Nikula
2019-08-26 18:05 ` [PATCH v8 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux David Francis
2019-08-26 19:16 ` Francis, David
2019-08-26 20:27 ` Lyude Paul
2019-08-26 20:51 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3aaa435-cc80-ef71-cd6e-3183590defe1@amd.com \
--to=hwentlan@amd.com \
--cc=David.Francis@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.