Re: [RFC PATCH v4] ndctl: monitor: add ndctl monitor daemon

From: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [RFC PATCH v4] ndctl: monitor: add ndctl monitor daemon
Date: Fri, 16 Mar 2018 19:01:47 +0900	[thread overview]
Message-ID: <d4c441ad-0607-3cca-6740-63861488eaf6@jp.fujitsu.com> (raw)
In-Reply-To: <20180316163309.7296.E1E9C6FF@jp.fujitsu.com>

On 2018/03/16 16:33, Yasunori Goto wrote:
>>>   b) About using systemctl command
>>>      3) Should we need to limit the maximum number of running daemons to be one?
>>>         If yes, I am thinking the option should support multiple values, then
>>>         users can modify the default configuration by using [--conf-file] option.
>>>         # ndctl monitor --dimm nmem1,nmem2 --conf-file
> I talked about here with Qi-san, and probably I understand what he really
> wanted to ask here.
>
> Currently, ndctl user can specify just "one" filter option, like --dimm nmem1,
> but he/she can not specify 2 or more options like --dimm nmem1,nmem2,nmem3.
>
> So, he would like to ask which we should select in the following.
>
>    a) Change ndctl for users to be able to specify multiple filter option.
>       This change affects not only daemon, but also ndctl list command.
>       In addition, we need to decide how much filter can be specified.
>    b) Keep current filter.
>       To monitor plural area(dimm/region/namespace/bus), plural daemons
>       are executed for each area which is specified one option.
>       This does not require option change.
>
> Though Qi-san wanted to select b) at this question,
> it is just workaround, we should select a) I think...
>
> Thanks,
>
Goto-san, Thank you for your follow.

I am not sure if it is needed to support "one option multiple arguments" 
in ndctl list.
Think more about it, I am thinking it should be supported in ndctl 
monitor daemon.
If ndctl list does not need it, it can be implemented only in monitor 
daemon.
If list also needs it, we can discuss more details about how to make a 
given one
which can be shared between list and monitor.

Thank you.

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm