All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jocelyn Falempe <jfalempe@redhat.com>
To: Linux regressions mailing list <regressions@lists.linux.dev>,
	tzimmermann@suse.de, airlied@redhat.com,
	kuohsiang_chou@aspeedtech.com, jammy_huang@aspeedtech.com,
	jani.nikula@linux.intel.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/ast: report connection status on Display Port.
Date: Mon, 10 Jul 2023 10:12:33 +0200	[thread overview]
Message-ID: <d4ca4cab-fed3-0b3e-5563-800bed43e5b2@redhat.com> (raw)
In-Reply-To: <62460153-04b1-b1aa-7966-45be16f3ec43@leemhuis.info>

On 06/07/2023 15:03, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 06.07.23 11:58, Jocelyn Falempe wrote:
>> Aspeed always report the display port as "connected", because it
>> doesn't set a .detect callback.
>> Fix this by providing the proper detect callback for astdp and dp501.
>>
>> This also fixes the following regression:
>> Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no
>>   EDID on DP")
>> The default resolution is now 640x480 when no monitor is connected.
>> But Aspeed graphics is mostly used in servers, where no monitor
>> is attached. This also affects the remote BMC resolution to 640x480,
>> which is inconvenient, and breaks the anaconda installer.
>>
>> v2: Add .detect callback to the dp/dp501 connector (Jani Nikula)
>>
>> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
> 
> So if this "also fixes a regression" how about a Fixes: tag and a CC:
> <stable tag to ensure this is not only fixed in latest mainline, but
> also in all affected stable and longterm kernels?

In this case, the regression only affect one userspace program 
(anaconda), and the fix looks too risky to backport to all stable kernels.
I've to prepare a v3, as this one breaks on hardware were there is only 
one Display Port connector and no VGA connector.

> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
> 

Best regards,

-- 

Jocelyn


  reply	other threads:[~2023-07-10  8:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06  9:58 [PATCH v2] drm/ast: report connection status on Display Port Jocelyn Falempe
2023-07-06 13:03 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-06 13:03   ` Linux regression tracking (Thorsten Leemhuis)
2023-07-10  8:12   ` Jocelyn Falempe [this message]
2023-07-10  8:26     ` Linux regression tracking (Thorsten Leemhuis)
2023-07-10  6:57 ` Thomas Zimmermann
2023-07-10  8:48   ` Jocelyn Falempe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4ca4cab-fed3-0b3e-5563-800bed43e5b2@redhat.com \
    --to=jfalempe@redhat.com \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jammy_huang@aspeedtech.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=kuohsiang_chou@aspeedtech.com \
    --cc=regressions@lists.linux.dev \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.