From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Cc: agross@kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, andersson@kernel.org,
bhupesh.linux@gmail.com, robh+dt@kernel.org,
konrad.dybcio@linaro.org, rfoss@kernel.org,
neil.armstrong@linaro.org
Subject: Re: [PATCH v2 03/10] dt-bindings: qcom-qce: Fix compatibles combinations for SM8150 and IPQ4019 SoCs
Date: Mon, 27 Mar 2023 14:19:20 +0200 [thread overview]
Message-ID: <d5821429-032d-e1e6-3a4e-ca19eb4a60ed@linaro.org> (raw)
In-Reply-To: <333081a2-6b31-3fca-1a95-4273b5a46fb7@linaro.org>
On 27/03/2023 13:49, Vladimir Zapolskiy wrote:
> Hi Bhupesh,
>
> On 3/22/23 13:45, Bhupesh Sharma wrote:
>> Currently the compatible list available in 'qce' dt-bindings does not
>> support SM8150 and IPQ4019 SoCs directly, leading to following
>> 'dtbs_check' error:
>>
>> arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dtb:
>> crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed:
>> ['qcom,sm8150-qce', 'qcom,qce'] is too long
>> ['qcom,sm8150-qce', 'qcom,qce'] is too short
>>
>> Fix the same.
>>
>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>> ---
>> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>> index e375bd981300..90ddf98a6df9 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>> @@ -24,6 +24,12 @@ properties:
>> deprecated: true
>> description: Kept only for ABI backward compatibility
>>
>> + - items:
>> + - enum:
>> + - qcom,ipq4019-qce
>> + - qcom,sm8150-qce
>> + - const: qcom,qce
>> +
>
> thank you for the fix, the change is correct, please apply the tag:
>
> Fixes: 00f3bc2db351 ("dt-bindings: qcom-qce: Add new SoC compatible strings for Qualcomm QCE IP")
>
> But let me ask you to split the "items" into two:
>
> - items:
> - const: qcom,ipq4019-qce
> - const: qcom,qce
>
> - items:
> - const: qcom,sm8150-qce
> - const: qcom,qce
>
Why splitting these? The enum is the preferred way usually, so why here
do it differently?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-27 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:45 [PATCH v2 00/10] arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 01/10] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 02/10] dt-bindings: dma: Increase iommu maxItems for BAM DMA Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 03/10] dt-bindings: qcom-qce: Fix compatibles combinations for SM8150 and IPQ4019 SoCs Bhupesh Sharma
2023-03-27 11:49 ` Vladimir Zapolskiy
2023-03-27 12:19 ` Krzysztof Kozlowski [this message]
2023-03-28 5:12 ` Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 04/10] dt-bindings: qcom-qce: Add compatibles for SM6115 and QCM2290 Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 05/10] arm64: dts: qcom: sdm845: Fix the BAM DMA engine compatible string Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 06/10] arm64: dts: qcom: sm6115: Add Crypto Engine support Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 07/10] arm64: dts: qcom: sm8150: " Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 08/10] arm64: dts: qcom: sm8250: " Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 09/10] arm64: dts: qcom: sm8350: " Bhupesh Sharma
2023-03-22 11:45 ` [PATCH v2 10/10] arm64: dts: qcom: sm8450: add crypto nodes Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5821429-032d-e1e6-3a4e-ca19eb4a60ed@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.