All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hauke Mehrtens <hauke@hauke-m.de>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Cc: sumit.garg@linaro.org, Johannes Berg <johannes.berg@intel.com>,
	Jouni Malinen <j@w1.fi>,
	kernel test robot <rong.a.chen@intel.com>,
	Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] mac80211: populate debugfs only after cfg80211 init
Date: Fri, 24 Apr 2020 20:52:12 +0200	[thread overview]
Message-ID: <d5d1d547-8eca-7ff4-a637-6b29ef1f15f4@hauke-m.de> (raw)
In-Reply-To: <20200423111344.0e00d3346f12.Iadc76a03a55093d94391fc672e996a458702875d@changeid>

On 4/23/20 11:13 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> When fixing the initialization race, we neglected to account for
> the fact that debugfs is initialized in wiphy_register(), and
> some debugfs things went missing (or rather were rerooted to the
> global debugfs root).
> 
> Fix this by adding debugfs entries only after wiphy_register().
> This requires some changes in the rate control code since it
> currently adds debugfs at alloc time, which can no longer be
> done after the reordering.
> 
> Reported-by: Jouni Malinen <j@w1.fi>
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
> Reported-by: Felix Fietkau <nbd@nbd.name>
> Fixes: 52e04b4ce5d0 ("mac80211: fix race in ieee80211_register_hw()")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
Cc: stable@vger.kernel.org

This should be backported to stable as the patch which causes these
problems was backported too.

Hauke

      parent reply	other threads:[~2020-04-24 18:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23  9:13 [PATCH] mac80211: populate debugfs only after cfg80211 init Johannes Berg
2020-04-23 12:52 ` Sumit Garg
2020-04-24 18:52 ` Hauke Mehrtens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5d1d547-8eca-7ff4-a637-6b29ef1f15f4@hauke-m.de \
    --to=hauke@hauke-m.de \
    --cc=j@w1.fi \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=rong.a.chen@intel.com \
    --cc=sumit.garg@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.