From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
Luca Fancellu <luca.fancellu@arm.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "bertrand.marquis@arm.com" <bertrand.marquis@arm.com>,
"wei.chen@arm.com" <wei.chen@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
George Dunlap <George.Dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [REGRESSION] Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools
Date: Tue, 17 May 2022 15:08:16 +0200 [thread overview]
Message-ID: <d64b7a15-8c67-dbca-6413-cd75ad372328@suse.com> (raw)
In-Reply-To: <e434527b-5804-324c-3619-51a552802d2f@citrix.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1145 bytes --]
On 17.05.22 15:01, Andrew Cooper wrote:
> On 06/05/2022 13:00, Luca Fancellu wrote:
>> Introduce domain-cpupool property of a xen,domain device tree node,
>> that specifies the cpupool device tree handle of a xen,cpupool node
>> that identifies a cpupool created at boot time where the guest will
>> be assigned on creation.
>>
>> Add member to the xen_domctl_createdomain public interface so the
>> XEN_DOMCTL_INTERFACE_VERSION version is bumped.
>>
>> Add public function to retrieve a pool id from the device tree
>> cpupool node.
>>
>> Update documentation about the property.
>>
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>
> This has broken the Ocaml bindings, and is conceptually wrong.
>
> The cpupool to use is a property of the vcpu, not the domain. It isn't
> legitimately part of createdomain.
What?
All vcpus of a domain are always in the same cpupool. There is no operation
"move vcpu to cpupool", but "move domain to cpupool". So your claim that
the cpupool wouldn't be a property of the domain is IMO wrong.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2022-05-17 13:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 12:00 [PATCH v8 0/7] Boot time cpupools Luca Fancellu
2022-05-06 12:00 ` [PATCH v8 1/7] tools/cpupools: Give a name to unnamed cpupools Luca Fancellu
2022-05-06 12:00 ` [PATCH v8 2/7] xen/sched: create public function for cpupools creation Luca Fancellu
2022-05-06 12:00 ` [PATCH v8 3/7] xen/sched: retrieve scheduler id by name Luca Fancellu
2022-05-06 12:00 ` [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time Luca Fancellu
2022-05-06 12:58 ` Juergen Gross
2022-05-06 17:38 ` Stefano Stabellini
2022-05-09 15:35 ` George Dunlap
2022-05-06 12:00 ` [PATCH v8 5/7] xen/cpupool: Don't allow removing cpu0 from cpupool0 Luca Fancellu
2022-05-06 12:00 ` [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Luca Fancellu
2022-05-06 13:06 ` Juergen Gross
2022-05-17 13:01 ` [REGRESSION] " Andrew Cooper
2022-05-17 13:08 ` Juergen Gross [this message]
2022-05-17 13:10 ` Andrew Cooper
2022-05-17 13:12 ` [REGRESSION] " Luca Fancellu
2022-05-06 12:00 ` [PATCH v8 7/7] xen/cpupool: Allow cpupool0 to use different scheduler Luca Fancellu
2022-05-09 20:35 ` [PATCH v8 0/7] Boot time cpupools Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d64b7a15-8c67-dbca-6413-cd75ad372328@suse.com \
--to=jgross@suse.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=dfaggioli@suse.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=luca.fancellu@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.