Re: [PATCH V6 net-next 3/4] net: hns3: dump more reg info based on ras mod

From: Jijie Shao <shaojijie@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
	<salil.mehta@huawei.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <pabeni@redhat.com>, <jiri@resnulli.us>,
	<horms@kernel.org>, <rkannoth@marvell.com>,
	<shenjian15@huawei.com>, <wangjie125@huawei.com>,
	<liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V6 net-next 3/4] net: hns3: dump more reg info based on ras mod
Date: Fri, 29 Mar 2024 18:34:02 +0800	[thread overview]
Message-ID: <d6c779a5-e4b1-4f21-b4f0-6b37b212890f@huawei.com> (raw)
In-Reply-To: <20240328191130.47242c8f@kernel.org>

on 2024/3/29 10:11, Jakub Kicinski wrote:
> On Wed, 27 Mar 2024 19:43:29 +0800 Jijie Shao wrote:
>> +	}, {
>> +		.reg_name = "MIB_TX/RX_BAD_PKTS",
>> +		.reg_offset_group = {19, 18, 29, 28},
>> +		.group_size = 4
>> +	}, {
>> +		.reg_name = "MIB_TX/RX_GOOD_PKTS",
>> +		.reg_offset_group = {21, 20, 31, 30},
>> +		.group_size = 4
>> +	}, {
>> +		.reg_name = "MIB_TX/RX_TOTAL_PKTS",
>> +		.reg_offset_group = {23, 22, 33, 32},
>> +		.group_size = 4
>> +	}, {
>> +		.reg_name = "MIB_TX/RX_PAUSE_PKTS",
>> +		.reg_offset_group = {25, 24, 35, 34},
>> +		.group_size = 4
>> +	}, {
>> +		.reg_name = "MIB_TX_ERR_ALL_PKTS",
>> +		.reg_offset_group = {27, 26},
>> +		.group_size = 2
>> +	}, {
>> +		.reg_name = "MIB_RX_FCS_ERR_PKTS",
>> +		.reg_offset_group = {37, 36},
>> +		.group_size = 2
> These seem to be duplicating standard stats from rtnl_link_stats64,
> ethtool_pause_stats, ethtool_eth_mac_stats, etc.
>
> You can add device specific stats, but please don't duplicate
> stats for which we have standard APIs.

Yeah, but these are not duplicate stats for ethtool or debugfs.

Generally, driver will reset to restore the normal state.
After the reset, many registers are cleared. Therefore,
it is difficult to analyze the reason of RAS.

We wang to add this information only when RAS is occurring, And
these information will help to analyze the reason of RAS.

these information does not appear in any new API.

Therefore, we hope that we can add this information to
reduce the difficulty of analyzing certain issues.

Jijie