From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>
Cc: Support Opensource <support.opensource@diasemi.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Steve Twiss <stwiss.opensource@diasemi.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v5 8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema
Date: Wed, 13 Dec 2023 07:40:13 +0100 [thread overview]
Message-ID: <d7846388-a31f-46c9-9c0d-738b9c69f3cf@linaro.org> (raw)
In-Reply-To: <20231210134717.94020-9-biju.das.jz@bp.renesas.com>
On 10/12/2023 14:47, Biju Das wrote:
> Convert the da9062 PMIC device tree binding documentation to json-schema.
>
> Document the missing gpio child node for da9062.
>
> While at it, update description with link to product information and
> example.
>
> The missing child node with of_compatible defined in MFD_CELL_OF is
> causing the below warning message:
> da9062-gpio: Failed to locate of_node [id: -1]
>
> So, make all child nodes with of_compatible defined in struct mfd_cell
> as required property for da906{1,2} devices.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Some explanation about gpio node and gpio-controller in the main device
would be indeed nice, as Conor suggested.
But anyway looks good to me. Thank you for the conversion to DT schema.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2023-12-13 6:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 13:47 [PATCH v5 0/8] Convert DA906{1,2} bindings to json-schema Biju Das
2023-12-10 13:47 ` [PATCH v5 1/8] dt-bindings: mfd: da9062: Update watchdog description Biju Das
2023-12-10 13:47 ` [PATCH v5 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog Biju Das
2023-12-10 15:20 ` Guenter Roeck
2023-12-10 13:47 ` [PATCH v5 3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog Biju Das
2023-12-10 15:21 ` Guenter Roeck
2023-12-10 13:47 ` [PATCH v5 4/8] dt-bindings: mfd: dlg,da9063: Update watchdog child node Biju Das
2023-12-10 13:47 ` [PATCH v5 5/8] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema Biju Das
2023-12-10 13:47 ` [PATCH v5 6/8] dt-bindings: thermal: Convert da906{1,2} thermal " Biju Das
2023-12-19 18:10 ` Daniel Lezcano
2023-12-10 13:47 ` [PATCH v5 7/8] dt-bindings: mfd: dlg,da9063: Sort child devices Biju Das
2023-12-10 13:47 ` [PATCH v5 8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema Biju Das
2023-12-11 18:37 ` Conor Dooley
2023-12-11 18:51 ` Biju Das
2023-12-12 16:54 ` Conor Dooley
2023-12-12 17:16 ` Biju Das
2023-12-11 19:10 ` Biju Das
2023-12-13 6:40 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7846388-a31f-46c9-9c0d-738b9c69f3cf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.