From: Chao Yu <chao@kernel.org>
To: Eric Biggers <ebiggers3@gmail.com>, linux-fscrypt@vger.kernel.org
Cc: "Theodore Y . Ts'o" <tytso@mit.edu>,
Eric Biggers <ebiggers@google.com>,
Michael Halcrow <mhalcrow@google.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 00/25] fscrypt: add some higher-level helper functions
Date: Thu, 21 Sep 2017 22:19:49 +0800 [thread overview]
Message-ID: <d7d91976-65b9-63d9-f34e-b322a9d0c472@kernel.org> (raw)
In-Reply-To: <20170920224605.22030-1-ebiggers3@gmail.com>
On 2017/9/21 6:45, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> This series reduces code duplication among ext4, f2fs, and ubifs by
> introducing a S_ENCRYPTED inode flag (so we don't have to call back into
> the filesystem to test the filesystem-specific inode flag), then
> introducing new helper functions that are called at the beginning of the
> open, link, rename, lookup, and setattr operations.
>
> In the future we maybe should even call these new helpers from the VFS
> so that each individual filesystem doesn't have to do it. But that's
> not possible currently because fs/crypto/ can be built as a module.
>
> Making changes like this is a bit challenging due to interdependencies
> between fscrypt and the individual filesystems, all of which have
> different maintainers. For now my intent is that patches 1-10 be taken
> through the fscrypt tree --- though it's not perfect since patches 1-4
> do make some changes to each filesystem, as everyone must set
> S_ENCRYPTED before we can use it everywhere in the shared code. But
> afterwards, patches 11-25 can be picked up by the individual filesystems
> to switch to the new helpers.
For all patches touching f2fs, looks good to me, feel free to add:
Reviewed-by: Chao Yu <yuchao0@huawei.com>
>
> Eric Biggers (25):
> fs, fscrypt: add an S_ENCRYPTED inode flag
> fscrypt: switch from ->is_encrypted() to IS_ENCRYPTED()
> fscrypt: remove ->is_encrypted()
> fscrypt: remove unneeded empty fscrypt_operations structs
> fscrypt: new helper function - fscrypt_require_key()
> fscrypt: new helper function - fscrypt_file_open()
> fscrypt: new helper function - fscrypt_prepare_link()
> fscrypt: new helper function - fscrypt_prepare_rename()
> fscrypt: new helper function - fscrypt_prepare_lookup()
> fscrypt: new helper function - fscrypt_prepare_setattr()
> ext4: switch to fscrypt_file_open()
> ext4: switch to fscrypt_prepare_link()
> ext4: switch to fscrypt_prepare_rename()
> ext4: switch to fscrypt_prepare_lookup()
> ext4: switch to fscrypt_prepare_setattr()
> f2fs: switch to fscrypt_file_open()
> f2fs: switch to fscrypt_prepare_link()
> f2fs: switch to fscrypt_prepare_rename()
> f2fs: switch to fscrypt_prepare_lookup()
> f2fs: switch to fscrypt_prepare_setattr()
> ubifs: switch to fscrypt_file_open()
> ubifs: switch to fscrypt_prepare_link()
> ubifs: switch to fscrypt_prepare_rename()
> ubifs: switch to fscrypt_prepare_lookup()
> ubifs: switch to fscrypt_prepare_setattr()
>
> fs/crypto/Makefile | 2 +-
> fs/crypto/crypto.c | 2 +-
> fs/crypto/fname.c | 3 +-
> fs/crypto/hooks.c | 112 +++++++++++++++++++++++++++++
> fs/crypto/keyinfo.c | 2 +-
> fs/crypto/policy.c | 6 +-
> fs/ext4/file.c | 23 ++----
> fs/ext4/inode.c | 19 +++--
> fs/ext4/namei.c | 62 +++++-----------
> fs/ext4/super.c | 15 ++--
> fs/f2fs/f2fs.h | 1 +
> fs/f2fs/file.c | 30 ++------
> fs/f2fs/inode.c | 5 +-
> fs/f2fs/namei.c | 54 ++++----------
> fs/f2fs/super.c | 7 +-
> fs/ubifs/crypto.c | 1 -
> fs/ubifs/dir.c | 43 ++++-------
> fs/ubifs/file.c | 41 ++---------
> fs/ubifs/ioctl.c | 5 +-
> fs/ubifs/super.c | 8 +--
> fs/ubifs/ubifs.h | 9 +--
> fs/ubifs/xattr.c | 1 +
> include/linux/fs.h | 2 +
> include/linux/fscrypt_common.h | 1 -
> include/linux/fscrypt_notsupp.h | 54 +++++++++++++-
> include/linux/fscrypt_supp.h | 153 ++++++++++++++++++++++++++++++++++++++++
> 26 files changed, 418 insertions(+), 243 deletions(-)
> create mode 100644 fs/crypto/hooks.c
>
prev parent reply other threads:[~2017-09-21 14:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 22:45 [PATCH 00/25] fscrypt: add some higher-level helper functions Eric Biggers
2017-09-20 22:45 ` [PATCH 01/25] fs, fscrypt: add an S_ENCRYPTED inode flag Eric Biggers
2017-09-20 22:45 ` [PATCH 02/25] fscrypt: switch from ->is_encrypted() to IS_ENCRYPTED() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 03/25] fscrypt: remove ->is_encrypted() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 04/25] fscrypt: remove unneeded empty fscrypt_operations structs Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 05/25] fscrypt: new helper function - fscrypt_require_key() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 06/25] fscrypt: new helper function - fscrypt_file_open() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 07/25] fscrypt: new helper function - fscrypt_prepare_link() Eric Biggers
2017-09-20 22:45 ` [PATCH 08/25] fscrypt: new helper function - fscrypt_prepare_rename() Eric Biggers
2017-09-20 22:45 ` [PATCH 09/25] fscrypt: new helper function - fscrypt_prepare_lookup() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 10/25] fscrypt: new helper function - fscrypt_prepare_setattr() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 11/25] ext4: switch to fscrypt_file_open() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 12/25] ext4: switch to fscrypt_prepare_link() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 13/25] ext4: switch to fscrypt_prepare_rename() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 14/25] ext4: switch to fscrypt_prepare_lookup() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 15/25] ext4: switch to fscrypt_prepare_setattr() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 16/25] f2fs: switch to fscrypt_file_open() Eric Biggers
2017-09-20 22:45 ` [PATCH 17/25] f2fs: switch to fscrypt_prepare_link() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:45 ` [PATCH 18/25] f2fs: switch to fscrypt_prepare_rename() Eric Biggers
2017-09-20 22:45 ` [PATCH 19/25] f2fs: switch to fscrypt_prepare_lookup() Eric Biggers
2017-09-20 22:45 ` Eric Biggers
2017-09-20 22:46 ` [PATCH 20/25] f2fs: switch to fscrypt_prepare_setattr() Eric Biggers
2017-09-20 22:46 ` Eric Biggers
2017-09-20 22:46 ` [PATCH 21/25] ubifs: switch to fscrypt_file_open() Eric Biggers
2017-09-20 22:46 ` Eric Biggers
2017-09-20 22:46 ` [PATCH 22/25] ubifs: switch to fscrypt_prepare_link() Eric Biggers
2017-09-20 22:46 ` Eric Biggers
2017-09-20 22:46 ` [PATCH 23/25] ubifs: switch to fscrypt_prepare_rename() Eric Biggers
2017-09-20 22:46 ` Eric Biggers
2017-09-20 22:46 ` [PATCH 24/25] ubifs: switch to fscrypt_prepare_lookup() Eric Biggers
2017-09-20 22:46 ` [PATCH 25/25] ubifs: switch to fscrypt_prepare_setattr() Eric Biggers
2017-09-21 6:45 ` [PATCH 00/25] fscrypt: add some higher-level helper functions Dave Chinner
2017-09-21 17:47 ` Eric Biggers
2017-09-21 20:48 ` Dave Chinner
2017-09-21 14:19 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d91976-65b9-63d9-f34e-b322a9d0c472@kernel.org \
--to=chao@kernel.org \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mhalcrow@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.