Re: [Qemu-devel] [PATCH v7 09/11] authz: add QAuthZListFile object type for a file access control list - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Eric Blake" <eblake@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 09/11] authz: add QAuthZListFile object type for a file access control list
Date: Thu, 6 Dec 2018 16:58:36 +0100	[thread overview]
Message-ID: <d7e633c1-2216-fd2b-dd36-41df5c264f0a@redhat.com> (raw)
In-Reply-To: <5d9b6cdf-3d6b-a424-daa1-e5a498920f59@redhat.com>

On 12/5/18 10:55 PM, Eric Blake wrote:
> On 12/5/18 11:23 AM, Philippe Mathieu-Daudé wrote:
>> On 11/30/18 3:06 PM, Daniel P. Berrangé wrote:
>>> Add a QAuthZListFile object type that implements the QAuthZ
>>> interface. This
>>> built-in implementation is a proxy around the QAuthZList object type,
>>> initializing it from an external file, and optionally, automatically
>>> reloading it whenever it changes.
>>>
>>> To create an instance of this object via the QMP monitor, the syntax
>>> used would be:
>>>
>>>        {
>>>          "execute": "object-add",
>>>          "arguments": {
>>>            "qom-type": "authz-list-file",
>>>            "id": "authz0",
>>>            "parameters": {
>>
>> "parameters" -> "props"
>>
>>>              "filename": "/etc/qemu/vnc.acl",
>>>         "refresh": "yes"
>>
>> I had to use "refresh": yes (value unquoted) to avoid:
> 
> Do you mean "refresh":true?  (bare yes is not valid JSON, but bare true
> is the correct way for a JSON bool).

I first tried 'true' then was curious and tried 'yes' and it worked too...