Re: [PATCH 1/2] thermal: db8500: Finalize device tree conversion

From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/2] thermal: db8500: Finalize device tree conversion
Date: Wed, 28 Aug 2019 11:04:10 +0200	[thread overview]
Message-ID: <d80f7c5f-2242-2216-9c98-02344f483781@linaro.org> (raw)
In-Reply-To: <CACRpkdZ6rnV8isO4SF86jiY2E2pbR9f2OBKYQBbML53A90WCig@mail.gmail.com>

On 28/08/2019 10:57, Linus Walleij wrote:
> On Tue, Aug 27, 2019 at 3:54 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>> On 27/08/2019 15:07, Linus Walleij wrote:
> 
>>> I think this is something that should be done inside the
>>> driver, not by abusing the trip points, so I try to rewrite the logic
>>> so that the driver fires these IRQs internally without using any
>>> trip points from the thermal subsystem.
>>
>> In the comments, it is mentioned something is missing with the PRCMU but
>> when the interface will be available, the get_temp won't have to
>> interpolate. Wouldn't make sense to add the PRCMU interface instead ?
> 
> Yes. But this is a firmware that I cannot rewrite or control,
> and which is preinstalled on a lot of shipped devices, so we
> cannot fix it that way. It was more a suggestion for internal
> development in later generations at the time :(

The THSENS_TEMP register gives invalid values because of the firmware?

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog