From: Fernando Pacheco <fernando.pacheco@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915/uc: Place uC firmware in upper range of GGTT
Date: Tue, 9 Apr 2019 16:18:46 -0700 [thread overview]
Message-ID: <d8871815-2fb0-8f67-b3b5-47933aeda0a1@intel.com> (raw)
In-Reply-To: <155484787184.692.14948569441690313321@skylake-alporthouse-com>
On 4/9/19 3:11 PM, Chris Wilson wrote:
> Quoting Fernando Pacheco (2019-04-09 22:31:01)
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>> index bf3d12f94365..160959785589 100644
>> --- a/drivers/gpu/drm/i915/i915_gem.c
>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>> @@ -4508,6 +4508,8 @@ void i915_gem_resume(struct drm_i915_private *i915)
>> i915_gem_restore_gtt_mappings(i915);
>> i915_gem_restore_fences(i915);
>>
>> + intel_uc_restore_ggtt_mapping(i915);
> No need, right? The fw ggtt binding is only temporary for the dma xfer.
On resume we re-init the uc hardware and perform the
upload again. Since I moved the binding to the uc init
phase I had to restore the mapping here. And it should
not have been called unconditionally...
Fernando
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-09 23:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 21:30 [PATCH 0/4] Perma-pin uC firmware and re-enable global reset Fernando Pacheco
2019-04-09 21:30 ` [PATCH 1/4] drm/i915/uc: Rename uC firmware init function Fernando Pacheco
2019-04-09 22:08 ` Chris Wilson
2019-04-09 21:31 ` [PATCH 2/4] drm/i915/uc: Reserve upper range of GGTT Fernando Pacheco
2019-04-09 21:41 ` Chris Wilson
2019-04-09 21:43 ` Chris Wilson
2019-04-09 22:40 ` Fernando Pacheco
2019-04-15 22:32 ` Fernando Pacheco
2019-04-16 7:21 ` Chris Wilson
2019-04-09 22:12 ` Daniele Ceraolo Spurio
2019-04-09 21:31 ` [PATCH 3/4] drm/i915/uc: Place uC firmware in " Fernando Pacheco
2019-04-09 21:53 ` Chris Wilson
2019-04-09 22:53 ` Fernando Pacheco
2019-04-09 23:04 ` Chris Wilson
2019-04-09 22:11 ` Chris Wilson
2019-04-09 23:18 ` Fernando Pacheco [this message]
2019-04-09 22:22 ` Chris Wilson
2019-04-16 14:51 ` Fernando Pacheco
2019-04-16 15:04 ` Chris Wilson
2019-04-16 15:21 ` Fernando Pacheco
2019-04-09 21:31 ` [PATCH 4/4] Revert "drm/i915/guc: Disable global reset" Fernando Pacheco
2019-04-09 21:54 ` Chris Wilson
2019-04-16 14:45 ` Fernando Pacheco
2019-04-16 15:05 ` Chris Wilson
2019-04-16 15:10 ` Fernando Pacheco
2019-04-09 22:31 ` ✗ Fi.CI.SPARSE: warning for Perma-pin uC firmware and re-enable global reset Patchwork
2019-04-09 22:56 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8871815-2fb0-8f67-b3b5-47933aeda0a1@intel.com \
--to=fernando.pacheco@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.