Re: [PATCH 2/3] bindings: hwmon: Add adi,adaq4224_temp as compatible string

From: Guenter Roeck <linux@roeck-us.net>
To: Daniel Matyas <daniel.matyas@analog.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/3] bindings: hwmon: Add adi,adaq4224_temp as compatible string
Date: Thu, 14 Dec 2023 07:15:13 -0800	[thread overview]
Message-ID: <d9ccf7ba-42e6-4ec6-9de9-51802e968de9@roeck-us.net> (raw)
In-Reply-To: <20231214143648.175336-2-daniel.matyas@analog.com>

On 12/14/23 06:36, Daniel Matyas wrote:
> In the device ada4224 the max31827 temperature sensor will be used, so
> the default values corresponding to adaq4224_temp are the same for
> max31827.
> 

I don't know what that device is, but if the max31827 is used it should
be instantiated as max31827.

Guenter

> Signed-off-by: Daniel Matyas <daniel.matyas@analog.com>
> ---
>   Documentation/devicetree/bindings/hwmon/adi,max31827.yaml | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> index f60e06ab7d0a..9f3b0839aa46 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> @@ -20,6 +20,7 @@ properties:
>         - const: adi,max31827
>         - items:
>             - enum:
> +              - adi,adaq4224_temp
>                 - adi,max31828
>                 - adi,max31829
>             - const: adi,max31827
> @@ -81,7 +82,9 @@ allOf:
>         properties:
>           compatible:
>             contains:
> -            const: adi,max31827
> +            enum:
> +              - adi,max31827
> +              - adi,adaq4224_temp
>   
>       then:
>         properties: