damon.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	SeongJae Park <sj@kernel.org>, <damon@lists.linux.dev>,
	<linux-mm@kvack.org>, <vishal.moola@gmail.com>,
	<david@redhat.com>
Subject: Re: [PATCH -next v2 1/7] mm: page_idle: Convert page idle to use folios
Date: Wed, 28 Dec 2022 09:18:23 +0800	[thread overview]
Message-ID: <0afd9944-d30a-c3e0-0fa3-4f609c49af84@huawei.com> (raw)
In-Reply-To: <Y6s2HPjrON2Sx/gr@casper.infradead.org>



On 2022/12/28 2:14, Matthew Wilcox wrote:
> On Tue, Dec 27, 2022 at 08:27:08PM +0800, Kefeng Wang wrote:
>> -static struct page *page_idle_get_page(unsigned long pfn)
>> +static struct folio *page_idle_get_folio(unsigned long pfn)
>>   {
>>   	struct page *page = pfn_to_online_page(pfn);
>> +	struct folio *folio;
>>   
>> -	if (!page || !PageLRU(page) ||
>> -	    !get_page_unless_zero(page))
>> +	if (!page || !PageLRU(page) || !get_page_unless_zero(page))
>>   		return NULL;
> 
> Mmmm, no.  PageLRU hides a compound_head() call.  Try doing this instead:
> 
> 	if (!page || PageTail(page))
> 		return NULL;
> 	folio = page_folio(page);
> 	if (!folio_test_lru(folio) || !folio_try_get(folio))
> 		return NULL;
> 	if (page_folio(page) != folio || !folio_test_lru(folio)) {
> 		folio_put(folio);
> 		folio = NULL;
> 	}
> 
Thanks Matthew, this is more complete, will update.
> 	return NULL;
> 
> 

  reply	other threads:[~2022-12-28  1:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-27 12:27 [PATCH -next v2 0/7] mm: convert page_idle/damon to use folios Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 1/7] mm: page_idle: Convert page idle " Kefeng Wang
2022-12-27 18:14   ` Matthew Wilcox
2022-12-28  1:18     ` Kefeng Wang [this message]
2022-12-27 12:27 ` [PATCH -next v2 2/7] mm: damon: introduce damon_get_folio() Kefeng Wang
2022-12-27 19:42   ` SeongJae Park
2022-12-27 19:49     ` Matthew Wilcox
2022-12-27 21:38       ` SeongJae Park
2022-12-28  2:06     ` Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 3/7] mm: damon: convert damon_ptep/pmdp_mkold() to use folios Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 4/7] mm: damon: paddr: convert damon_pa_*() " Kefeng Wang
2022-12-27 19:50   ` SeongJae Park
2022-12-28  1:26     ` Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 5/7] mm: damon: vaddr: convert damon_young_pmd_entry() to use folio Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 6/7] mm: damon: remove unneed damon_get_page() Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 7/7] mm: damon: vaddr: convert hugetlb related function to use folios Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0afd9944-d30a-c3e0-0fa3-4f609c49af84@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=david@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    --cc=vishal.moola@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).