From: Xin Hao <xhao@linux.alibaba.com>
To: sj@kernel.org
Cc: akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
xhao@linux.alibaba.com
Subject: [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk_arg
Date: Thu, 18 Aug 2022 18:57:32 +0800 [thread overview]
Message-ID: <20220818105732.34492-3-xhao@linux.alibaba.com> (raw)
In-Reply-To: <20220818105732.34492-1-xhao@linux.alibaba.com>
The struct of 'damon_lru_sort_ram_walk_arg' is the same with struct of
'damon_addr_range', so, there no need to redefine it, just use struct of
'damon_addr_range' instead.
Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
---
mm/damon/lru_sort.c | 34 +++++++++++++---------------------
1 file changed, 13 insertions(+), 21 deletions(-)
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index ac50dca026f9..a3674532fa67 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -257,18 +257,13 @@ module_param(nr_cold_quota_exceeds, ulong, 0400);
static struct damon_ctx *ctx;
static struct damon_target *target;
-struct damon_lru_sort_ram_walk_arg {
- unsigned long start;
- unsigned long end;
-};
-
static int walk_system_ram(struct resource *res, void *arg)
{
- struct damon_lru_sort_ram_walk_arg *a = arg;
+ struct damon_addr_range *r = arg;
- if (a->end - a->start < resource_size(res)) {
- a->start = res->start;
- a->end = res->end;
+ if (r->end - r->start < resource_size(res)) {
+ r->start = res->start;
+ r->end = res->end;
}
return 0;
}
@@ -277,16 +272,12 @@ static int walk_system_ram(struct resource *res, void *arg)
* Find biggest 'System RAM' resource and store its start and end address in
* @start and @end, respectively. If no System RAM is found, returns false.
*/
-static bool get_monitoring_region(unsigned long *start, unsigned long *end)
+static bool get_monitoring_region(struct damon_addr_range *range)
{
- struct damon_lru_sort_ram_walk_arg arg = {};
-
- walk_system_ram_res(0, ULONG_MAX, &arg, walk_system_ram);
- if (arg.end <= arg.start)
+ walk_system_ram_res(0, ULONG_MAX, range, walk_system_ram);
+ if (range->end <= range->start)
return false;
- *start = arg.start;
- *end = arg.end;
return true;
}
@@ -380,9 +371,12 @@ static int damon_lru_sort_apply_parameters(void)
if (monitor_region_start > monitor_region_end)
return -EINVAL;
- if (!monitor_region_start && !monitor_region_end &&
- !get_monitoring_region(&monitor_region_start,
- &monitor_region_end))
+ if (!monitor_region_end)
+ return -EINVAL;
+
+ addr_range.start = monitor_region_start;
+ addr_range.end = monitor_region_end;
+ if (!get_monitoring_region(&addr_range))
return -EINVAL;
err = damon_set_attrs(ctx, sample_interval, aggr_interval, 0,
@@ -408,8 +402,6 @@ static int damon_lru_sort_apply_parameters(void)
return -ENOMEM;
damon_add_scheme(ctx, scheme);
- addr_range.start = monitor_region_start;
- addr_range.end = monitor_region_end;
return damon_set_regions(target, &addr_range, 1);
}
--
2.27.0
next prev parent reply other threads:[~2022-08-18 11:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 10:57 [PATCH V2 0/2] mm/damon: A few fixup with lru_sort Xin Hao
2022-08-18 10:57 ` [PATCH V2 1/2] mm/damon/lru_sort: Move target memory region check to head of func Xin Hao
2022-08-18 17:11 ` SeongJae Park
2022-08-19 2:12 ` haoxin
2022-08-19 2:28 ` SeongJae Park
2022-08-19 2:47 ` haoxin
2022-08-19 4:52 ` SeongJae Park
2022-08-18 10:57 ` Xin Hao [this message]
2022-08-18 17:23 ` [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk_arg SeongJae Park
2022-08-19 1:56 ` haoxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818105732.34492-3-xhao@linux.alibaba.com \
--to=xhao@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).