damon.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Vishal Moola <vishal.moola@gmail.com>
To: SeongJae Park <sj@kernel.org>
Cc: linux-mm@kvack.org, damon@lists.linux.dev,
	linux-kernel@vger.kernel.org,  akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] damon: Convert damon_pa_mark_accessed_or_deactivate() to use folios
Date: Tue, 6 Dec 2022 18:43:57 -0800	[thread overview]
Message-ID: <CAOzc2pwexH7Phhg_Dx0_9dg5_3n=uKSwbpWDKBbNQdY0N97U-Q@mail.gmail.com> (raw)
In-Reply-To: <20221207005624.146281-1-sj@kernel.org>

On Tue, Dec 6, 2022 at 4:56 PM SeongJae Park <sj@kernel.org> wrote:
>
> Hi Vishal,
>
>
> Thank you for this patch.
>
> Nit pick.  Could we please replace 'damon:' on the subject with 'mm/damon:' to
> look more consistent with other DAMON patches?

Thanks for looking over this patch! I'll make the subject mm/damon in a v2.

> On Tue, 6 Dec 2022 16:21:57 -0800 "Vishal Moola (Oracle)" <vishal.moola@gmail.com> wrote:
>
> > This change replaces 2 calls to compound_head() with one.
>
> I guess you mean _compound_head() calls in page_folio() that called from
> mark_page_accessed() and folio_mark_accessed().  However, deactivate_page()
> calls page_folio() anyway, so this patch doesn't reduce the number of calls to
> one but keep the number, correct?  Am I missing something?  If I'm not, I'd
> like to clean up the wording.

The 2 calls I was referring to were from mark_page_accessed() and put_page().
As you've noticed, deactivate_page() still calls page_folio() here :).

> > This is in preparation for the conversion of deactivate_page() to
> > deactivate_folio().
>
> I think folio_deactivate() might be a more consistent naming.  What do you
> think?

I do like the name folio_deactivate() better than deactivate_folio(), I'll
change that in v2 as well.

  parent reply	other threads:[~2022-12-07  2:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07  0:21 [PATCH 0/3] Convert deactivate_page() to deactivate_folio() Vishal Moola (Oracle)
2022-12-07  0:21 ` [PATCH 1/3] madvise: Convert madvise_cold_or_pageout_pte_range() to use folios Vishal Moola (Oracle)
2022-12-07  9:47   ` kernel test robot
2022-12-07 23:46   ` kernel test robot
2022-12-07  0:21 ` [PATCH 2/3] damon: Convert damon_pa_mark_accessed_or_deactivate() " Vishal Moola (Oracle)
2022-12-07  0:56   ` SeongJae Park
2022-12-07  1:04     ` SeongJae Park
2022-12-07  2:43     ` Vishal Moola [this message]
2022-12-07  0:21 ` [PATCH 3/3] swap: Convert deactivate_page() to deactivate_folio() Vishal Moola (Oracle)
2022-12-07 16:18   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOzc2pwexH7Phhg_Dx0_9dg5_3n=uKSwbpWDKBbNQdY0N97U-Q@mail.gmail.com' \
    --to=vishal.moola@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).