damon.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: SeongJae Park <sj@kernel.org>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	vishal.moola@gmail.com, david@redhat.com
Subject: Re: [PATCH -next v2 2/7] mm: damon: introduce damon_get_folio()
Date: Tue, 27 Dec 2022 19:49:56 +0000	[thread overview]
Message-ID: <Y6tMZNvTF4ZsoQEq@casper.infradead.org> (raw)
In-Reply-To: <20221227194257.2744-1-sj@kernel.org>

On Tue, Dec 27, 2022 at 07:42:57PM +0000, SeongJae Park wrote:
> > +static inline struct page *damon_get_page(unsigned long pfn)
> > +{
> > +	struct folio *folio = damon_get_folio(pfn);
> > +
> > +	return &folio->page;
> 
> I think we should check if folio is NULL before dereferencing it?

&folio->page does not dereeference folio.

  reply	other threads:[~2022-12-27 19:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-27 12:27 [PATCH -next v2 0/7] mm: convert page_idle/damon to use folios Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 1/7] mm: page_idle: Convert page idle " Kefeng Wang
2022-12-27 18:14   ` Matthew Wilcox
2022-12-28  1:18     ` Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 2/7] mm: damon: introduce damon_get_folio() Kefeng Wang
2022-12-27 19:42   ` SeongJae Park
2022-12-27 19:49     ` Matthew Wilcox [this message]
2022-12-27 21:38       ` SeongJae Park
2022-12-28  2:06     ` Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 3/7] mm: damon: convert damon_ptep/pmdp_mkold() to use folios Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 4/7] mm: damon: paddr: convert damon_pa_*() " Kefeng Wang
2022-12-27 19:50   ` SeongJae Park
2022-12-28  1:26     ` Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 5/7] mm: damon: vaddr: convert damon_young_pmd_entry() to use folio Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 6/7] mm: damon: remove unneed damon_get_page() Kefeng Wang
2022-12-27 12:27 ` [PATCH -next v2 7/7] mm: damon: vaddr: convert hugetlb related function to use folios Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6tMZNvTF4ZsoQEq@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=david@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    --cc=vishal.moola@gmail.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).