From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: SeongJae Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <damon@lists.linux.dev>
Subject: Re: [PATCH v2 3/3] mm/damon/paddr: minor refactor of damon_pa_mark_accessed_or_deactivate()
Date: Mon, 6 Mar 2023 09:12:38 +0800 [thread overview]
Message-ID: <b3eff456-4c3d-3908-178f-4d9d6d4b23c7@huawei.com> (raw)
In-Reply-To: <20230303183722.113464-1-sj@kernel.org>
On 2023/3/4 2:37, SeongJae Park wrote:
> On Fri, 3 Mar 2023 18:26:33 +0000 SeongJae Park <sj@kernel.org> wrote:
>
>> On Fri, 3 Mar 2023 16:43:43 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>
>>> Omit one line by unified folio_put(), and make code more clear.
>>>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> ---
>>> mm/damon/paddr.c | 9 ++++-----
>>> 1 file changed, 4 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
>>> index 2ef9db0189ca..6930ebf3667c 100644
>>> --- a/mm/damon/paddr.c
>>> +++ b/mm/damon/paddr.c
>>> @@ -266,17 +266,16 @@ static inline unsigned long damon_pa_mark_accessed_or_deactivate(
>>> if (!folio)
>>> continue;
>>>
>>> - if (damos_pa_filter_out(s, folio)) {
>>> - folio_put(folio);
>>> - continue;
>>> - }
>>> + if (damos_pa_filter_out(s, folio))
>>> + goto put_folio;
>>>
>>> if (mark_accessed)
>>> folio_mark_accessed(folio);
>>> else
>>> folio_deactivate(folio);
>>> - folio_put(folio);
>>> applied += folio_nr_pages(folio);
>>> +put_folio:
>>> + folio_put(folio);
>>
>> I think this change is ok, but shouldn't the 'folio_put()' have called before
>
> s/before/after/
>
>> 'folio_nr_pages()' anyway? If so, could we make the change as a separate fix
>> first, and then make this change, so that it can be easily applied to relevant
>> stable kernels?
Yes, seem to previous one.
>>
>>
>> Thanks,
>> SJ
>>
>>> }
>>> return applied * PAGE_SIZE;
>>> }
>>> --
>>> 2.35.3
>>>
>>>
prev parent reply other threads:[~2023-03-06 1:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 8:43 [PATCH v2 0/3] mm/damon/paddr: minor code improvement Kefeng Wang
2023-03-03 8:43 ` [PATCH v2 1/3] mm/damon/paddr: minor refactor of damon_pa_pageout() Kefeng Wang
2023-03-03 18:41 ` SeongJae Park
2023-03-03 8:43 ` [PATCH v2 2/3] mm/damon/paddr: minor refactor of damon_pa_young() Kefeng Wang
2023-03-03 18:39 ` SeongJae Park
2023-03-06 1:10 ` Kefeng Wang
2023-03-06 1:56 ` Kefeng Wang
2023-03-06 21:27 ` SeongJae Park
2023-03-07 1:22 ` Kefeng Wang
2023-03-07 18:00 ` SeongJae Park
2023-03-08 1:03 ` Kefeng Wang
2023-03-03 8:43 ` [PATCH v2 3/3] mm/damon/paddr: minor refactor of damon_pa_mark_accessed_or_deactivate() Kefeng Wang
2023-03-03 18:26 ` SeongJae Park
2023-03-03 18:37 ` SeongJae Park
2023-03-06 1:12 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3eff456-4c3d-3908-178f-4d9d6d4b23c7@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).