damon.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: SeongJae Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	<damon@lists.linux.dev>, <linux-mm@kvack.org>,
	<vishal.moola@gmail.com>, <willy@infradead.org>,
	<david@redhat.com>
Subject: Re: [PATCH -next v3 0/7] mm: convert page_idle/damon to use folios
Date: Thu, 29 Dec 2022 10:16:19 +0800	[thread overview]
Message-ID: <b8a22086-0053-1da2-f7b1-2d60f484b800@huawei.com> (raw)
In-Reply-To: <20221228175504.149395-1-sj@kernel.org>



On 2022/12/29 1:55, SeongJae Park wrote:
> Hi Kefeng,
> 
> On Wed, 28 Dec 2022 19:34:06 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> 
>> v3:
>> - more thoroughly converting in page_idle_get_folio() suggested by Matthew
>>    also do it in damon_get_folio().
>> - address some commets from SeongJae
>>
>> v2:
>> - drop unsafe pfn_to_online_folio(), convert page_idle_get_page() and
>>    damon_get_page() to return a folio after grab a reference
>> - convert damon hugetlb related functions
>> - rebased on next-20221226.
>>
>> Kefeng Wang (7):
>>    mm: page_idle: Convert page idle to use folios
>>    mm/damon: introduce damon_get_folio()
>>    mm/damon: convert damon_ptep/pmdp_mkold() to use folios
>>    mm/damon: paddr: convert damon_pa_*() to use folios
>>    mm/damon: vaddr: convert damon_young_pmd_entry() to use folio
>>    mm/damon: remove unneed damon_get_page()
>>    mm/damon: vaddr: convert hugetlb related function to use folios
> 
> Thank you so much for your efforts on this work.  I found I forgot mentioning
> some trivial typos in the first, the sixth and the seventh patches, so
> commented.  I should have commented those earlier, sorry.
> 
Oh,please forgive my bad English spelling, and thanks for Andrew with 
corrected word when patches are queued.

> Other than those,
> 
> Reviewed-by: SeongJae Park <sj@kernel.org>

Thanks you very much.


> 
> 
> Thanks,
> SJ
> 
>>
>>   mm/damon/ops-common.c | 38 +++++++++++++++-------------
>>   mm/damon/ops-common.h |  2 +-
>>   mm/damon/paddr.c      | 58 +++++++++++++++++++------------------------
>>   mm/damon/vaddr.c      | 38 ++++++++++++++--------------
>>   mm/page_idle.c        | 47 ++++++++++++++++++-----------------
>>   5 files changed, 91 insertions(+), 92 deletions(-)
>>
>> -- 
>> 2.35.3
>>

      reply	other threads:[~2022-12-29  2:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28 11:34 [PATCH -next v3 0/7] mm: convert page_idle/damon to use folios Kefeng Wang
2022-12-28 11:34 ` [PATCH -next v3 1/7] mm: page_idle: convert page idle " Kefeng Wang
2022-12-28 17:46   ` SeongJae Park
2022-12-28 11:34 ` [PATCH -next v3 2/7] mm/damon: introduce damon_get_folio() Kefeng Wang
2022-12-28 22:36   ` Matthew Wilcox
2022-12-28 23:14     ` SeongJae Park
2022-12-28 11:34 ` [PATCH -next v3 3/7] mm/damon: convert damon_ptep/pmdp_mkold() to use folios Kefeng Wang
2022-12-28 11:34 ` [PATCH -next v3 4/7] mm/damon/paddr: convert damon_pa_*() " Kefeng Wang
2022-12-29 20:36   ` Matthew Wilcox
2022-12-30  6:40     ` Kefeng Wang
2022-12-28 11:34 ` [PATCH -next v3 5/7] mm/damon/vaddr: convert damon_young_pmd_entry() to use folio Kefeng Wang
2022-12-29 21:06   ` Matthew Wilcox
2022-12-29 21:31     ` SeongJae Park
2022-12-28 11:34 ` [PATCH -next v3 6/7] mm/damon: remove unneed damon_get_page() Kefeng Wang
2022-12-28 17:49   ` SeongJae Park
2022-12-28 11:34 ` [PATCH -next v3 7/7] mm/damon/vaddr: convert hugetlb related function to use folios Kefeng Wang
2022-12-28 17:51   ` SeongJae Park
2022-12-28 17:55 ` [PATCH -next v3 0/7] mm: convert page_idle/damon " SeongJae Park
2022-12-29  2:16   ` Kefeng Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8a22086-0053-1da2-f7b1-2d60f484b800@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=david@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    --cc=vishal.moola@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).