dash.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: maximilian attems <max@stro.at>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: klibc@zytor.com, dash@vger.kernel.org, maximilian attems <max@stro.at>
Subject: [PATCH] JOBS: fix klibc DEBUG compilation
Date: Fri,  3 Jun 2011 19:38:27 +0200	[thread overview]
Message-ID: <1307122707-30526-1-git-send-email-max@stro.at> (raw)

dash didn't compile in DEBUG mode against klibc for all long time.
Now it fails at link stage for not having setlinebuf(3).

Fixes:

usr/dash/show.o: In function `opentrace':
show.c:(.text+0x86): undefined reference to `setlinebuf'                        
Signed-off-by: maximilian attems <max@stro.at>
---

the last open error, looks more like a klibc bug to me,
will fix it there:
show.c:(.text+0x36): undefined reference to `freopen'                           

 src/show.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/show.c b/src/show.c
index 14dbef3..b4160e1 100644
--- a/src/show.c
+++ b/src/show.c
@@ -394,7 +394,9 @@ opentrace(void)
 	if ((flags = fcntl(fileno(tracefile), F_GETFL, 0)) >= 0)
 		fcntl(fileno(tracefile), F_SETFL, flags | O_APPEND);
 #endif
+#ifndef SMALL
 	setlinebuf(tracefile);
+#endif /* SMALL */
 	fputs("\nTracing started.\n", tracefile);
 }
 #endif /* DEBUG */
-- 
1.7.4.4


             reply	other threads:[~2011-06-03 17:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-03 17:38 maximilian attems [this message]
2011-06-03 18:13 ` [PATCH] JOBS: fix klibc DEBUG compilation Jilles Tjoelker
2011-06-04  6:45   ` maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307122707-30526-1-git-send-email-max@stro.at \
    --to=max@stro.at \
    --cc=dash@vger.kernel.org \
    --cc=herbert@gondor.hengli.com.au \
    --cc=klibc@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).