dash.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] create builtins.c properly on old cpp
@ 2014-12-22  5:50 kabe
  2014-12-25 22:52 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: kabe @ 2014-12-22  5:50 UTC (permalink / raw)
  To: dash; +Cc: kabe

Encontered this on ancient gcc-2.95.3 environment;
src/builtins.def.in -> src/builtins.def generation emitted
^ $
lines (likely by /* */), which where NOT ignored by 
src/mkbuiltins and generating bogus builtins.c.

-- kabe
\f
diff -U6 -p dash-0.5.8/src/mkbuiltins.dist dash-0.5.8/src/mkbuiltins
--- dash-0.5.8/src/mkbuiltins.dist	Sun Sep 28 17:19:32 2014
+++ dash-0.5.8/src/mkbuiltins	Mon Dec 22 14:36:43 2014
@@ -66,13 +66,13 @@ cat <<\!
  */
 
 #include "shell.h"
 #include "builtins.h"
 
 !
-< $builtins sed '/^#/d; /^$/d' > $temp
+< $builtins sed '/^#/d; /^ *$/d' > $temp
 awk '{	printf "int %s(int, char **);\n", $1}' $temp
 echo '
 const struct builtincmd builtincmd[] = {'
 awk '{	for (i = 2 ; i <= NF ; i++) {
 		line = $i "\t" $1
 		if ($i ~ /^-/)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] create builtins.c properly on old cpp
  2014-12-22  5:50 [PATCH] create builtins.c properly on old cpp kabe
@ 2014-12-25 22:52 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2014-12-25 22:52 UTC (permalink / raw)
  Cc: dash, kabe

kabe@sra-tohoku.co.jp wrote:
> Encontered this on ancient gcc-2.95.3 environment;
> src/builtins.def.in -> src/builtins.def generation emitted
> ^ $
> lines (likely by /* */), which where NOT ignored by 
> src/mkbuiltins and generating bogus builtins.c.

Patch applied.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-25 22:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-22  5:50 [PATCH] create builtins.c properly on old cpp kabe
2014-12-25 22:52 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).