From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Blake <eblake@redhat.com>
Cc: Fredrik Fornwall <fredrik@fornwall.net>, dash@vger.kernel.org
Subject: Re: [PATCH] Set LC_ALL instead LC_COLLATE in mkbuiltins
Date: Fri, 22 May 2015 12:45:15 +0800 [thread overview]
Message-ID: <20150522044515.GA32740@gondor.apana.org.au> (raw)
In-Reply-To: <555EB333.6000201@redhat.com>
On Thu, May 21, 2015 at 10:40:19PM -0600, Eric Blake wrote:
>
> Why do you care whether any errors printed by sort are in the "C" locale
> (in English) rather than localized? Ideally, there won't be any sort
> errors in the first place, because this tool is run on controlled input
> as part of the build process.
Your /tmp could be full or sort could be out of memory.
> Setting LC_ALL has the nice property that LC_COLLATE and LC_CTYPE are
> guaranteed to be compatible; if you just set LC_COLLATE but leave
> LC_CTYPE unchanged and unset LC_ALL, it is possible to attempt a
> collation that assumes one character set while still living in a ctype
> that assumes another, and get garbled results.
Show me an actual pair of values for these two that produce
incorrect results for mkbuiltins and I'll happily change both.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-05-22 4:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 23:15 Fredrik Fornwall
2015-05-22 4:25 ` Herbert Xu
2015-05-22 4:40 ` Eric Blake
2015-05-22 4:45 ` Herbert Xu [this message]
2015-05-22 13:02 ` Eric Blake
2015-05-24 21:05 ` Fredrik Fornwall
2015-05-26 2:49 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522044515.GA32740@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=eblake@redhat.com \
--cc=fredrik@fornwall.net \
--subject='Re: [PATCH] Set LC_ALL instead LC_COLLATE in mkbuiltins' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).