From: Herbert Xu <herbert@gondor.apana.org.au>
To: Harald van Dijk <harald@gigawatt.nl>
Cc: martijn@inlv.org, dash@vger.kernel.org
Subject: Re: getopts doesn't properly update OPTIND when called from function
Date: Fri, 29 May 2015 10:58:09 +0800 [thread overview]
Message-ID: <20150529025809.GA16240@gondor.apana.org.au> (raw)
In-Reply-To: <5567990E.3090902@gigawatt.nl>
Harald van Dijk <harald@gigawatt.nl> wrote:
> That isn't the problem, not exactly anyway. The problem is that getopts
> is required to keep internal state separately from the OPTIND variable
> (a single integer is insufficient to track the progress when multiple
> options are combined in a single word), and that internal state is
> stored along with the positional parameters. The positional parameters
> are saved just before a function call, and restored when the function
> returns. The internal state of getopts should not be saved the same way.
> It should probably just be global to dash.
I think the current behaviour is fine as far as POSIX is concerned.
It says:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/getopts.html
: APPLICATION USAGE
...
: Note that shell functions share OPTIND with the calling shell
: even though the positional parameters are changed. If the calling
: shell and any of its functions uses getopts to parse arguments,
: the results are unspecified.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-05-29 2:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 18:54 getopts doesn't properly update OPTIND when called from function Martijn Dekker
2015-05-28 22:39 ` Harald van Dijk
2015-05-29 2:58 ` Herbert Xu [this message]
2015-05-29 5:50 ` Harald van Dijk
2015-06-01 6:29 ` Herbert Xu
2015-06-01 17:30 ` Harald van Dijk
2015-06-01 22:10 ` Jilles Tjoelker
2015-06-02 0:21 ` Harald van Dijk
2015-06-04 19:56 ` Martijn Dekker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529025809.GA16240@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=harald@gigawatt.nl \
--cc=martijn@inlv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).