From: Martin Lucina <martin@lucina.net>
To: dash@vger.kernel.org, rumpkernel-users@freelists.org
Subject: Re: Dash commit 46d3c1a (in 0.5.8+) breaks BSD make
Date: Fri, 4 Mar 2016 16:48:41 +0100 [thread overview]
Message-ID: <20160304154841.GD2457@nodbug.lucina.net> (raw)
In-Reply-To: <56D99A91.2010901@rumpkernel.org>
On Friday, 04.03.2016 at 14:24, Antti Kantee wrote:
> On 04/03/16 14:06, Martin Lucina wrote:
> >Commit 46d3c1a ([VAR] Sanitise environment variable names on entry)
> >restricts exported environment variables actually set by dash on entry to
> >those reported as valid by endofname(). While this is technically correct
> >and matches IEEE Std 1003.1, it breaks BSD make which uses '.' as a
> >separator in variables exported via the environment to a sub-make.
>
> I wouldn't go so far as to say it breaks BSD make. Rather, it breaks a rare
> pattern where variables containing "." (where "." follows a certain
> convention) are passed to submakes via the shell (i.e. ".export" in the
> Makefile).
>
> >Would the dash maintainers consider replacing 46d3c1a with a fix that
> >performs the name validity check at "export -p" time instead? If yes, I can
> >try my hand at a patch.
>
> There are probably enough deployments of dash with this behaviour so that we
> need in any case need to remove the use of variables containing "." coupled
> with ".export" from Makefiles. Changing dash doesn't sound useful to me.
You're right -- I spoke too soon and thought this behaviour was a general
property of nbmake rather than our specific usage of it. Still, the
maintainers may want to note in dash documentation that sanitizing exported
variables can cause some applications depending on the non-POSIX behaviour
to fail.
prev parent reply other threads:[~2016-03-04 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 14:06 Dash commit 46d3c1a (in 0.5.8+) breaks BSD make Martin Lucina
2016-03-04 14:24 ` Antti Kantee
2016-03-04 15:48 ` Martin Lucina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304154841.GD2457@nodbug.lucina.net \
--to=martin@lucina.net \
--cc=dash@vger.kernel.org \
--cc=rumpkernel-users@freelists.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).