From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jonathan Perkin <jperkin@joyent.com>
Cc: dash@vger.kernel.org
Subject: Re: [SHELL] Fix 64-bit Solaris build
Date: Tue, 7 Jun 2016 14:50:59 +0800 [thread overview]
Message-ID: <20160607065059.GA29507@gondor.apana.org.au> (raw)
In-Reply-To: <20160606152259.GE5022@joyent.com>
On Mon, Jun 06, 2016 at 04:22:59PM +0100, Jonathan Perkin wrote:
>
> Right, it only exists as a macro, defined as
>
> #define stat64 stat
>
> in sys/stat.h. The AC_CHECK_FUNC test fails as it doesn't pull in any
> includes, and cannot find a stat64() function in libc.
>
> Adding the AC_CHECK_DECL test finds the definition and avoids running
> the AC_CHECK_FUNC tests if that is the case.
OK, how about just changing the AC_CHECK_FUNC to AC_CHECK_DECL?
Please resubmit the patch.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2016-06-07 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 13:07 [PATCH] [SHELL] Fix 64-bit Solaris build Jonathan Perkin
2016-06-06 14:27 ` Herbert Xu
2016-06-06 15:22 ` Jonathan Perkin
2016-06-07 6:50 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607065059.GA29507@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=jperkin@joyent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).