From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ron Yorston <rmy@frippery.org>
Cc: contact@emersion.fr, dash@vger.kernel.org
Subject: Re: [PATCH] parser: Catch errors in expandstr
Date: Fri, 28 Feb 2020 11:40:23 +1100 [thread overview]
Message-ID: <20200228004023.GA9163@gondor.apana.org.au> (raw)
In-Reply-To: <5e56df24.H24u7mxAPbLPL6fI%rmy@frippery.org>
On Wed, Feb 26, 2020 at 09:12:04PM +0000, Ron Yorston wrote:
> Herbert Xu wrote:
> >This patch fixes it by using the literal value of PS1 should an
> >error occur during expansion.
>
> There's another case that should be handled. PS1='`xxx(`' causes the
> shell to exit because the old-style backquote leaves an additional file
> on the stack.
>
> Signed-off-by: Ron Yorston <rmy@pobox.com>
> ---
> src/parser.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
When you send a patch to an existing thread could you please change
the Subject line? Otherwise your patch will be silently dropped by
patchwork.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-02-28 0:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SJhI_AW9YJmphaap5RzzVqYTGsA529iV7GOEBafT9ilDPGFpMRRJlNt3TrMBwh0uqKQltSvsH2P8x_2in6enHT5DzygjAtrRSvWl5xHofeY=@emersion.fr>
2020-01-21 6:39 ` [PATCH] parser: Catch errors in expandstr Herbert Xu
2020-01-21 17:06 ` Simon Ser
2020-02-26 21:12 ` Ron Yorston
2020-02-28 0:40 ` Herbert Xu [this message]
2020-04-28 6:17 ` [v2 PATCH] " Herbert Xu
2020-05-17 12:19 ` Harald van Dijk
2020-05-17 13:36 ` [PATCH] parser: Save and restore heredoclist " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228004023.GA9163@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=contact@emersion.fr \
--cc=dash@vger.kernel.org \
--cc=rmy@frippery.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).