dash.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Remove unused expandmeta() flag parameter
@ 2020-04-29  6:29 Denys Vlasenko
  2020-05-15  6:30 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Denys Vlasenko @ 2020-04-29  6:29 UTC (permalink / raw)
  To: Herbert Xu, dash; +Cc: Denys Vlasenko

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
---
 src/expand.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/expand.c b/src/expand.c
index 4a5d75a..985cd70 100644
--- a/src/expand.c
+++ b/src/expand.c
@@ -118,7 +118,7 @@ STATIC char *evalvar(char *, int);
 static size_t strtodest(const char *p, int flags);
 static size_t memtodest(const char *p, size_t len, int flags);
 STATIC ssize_t varvalue(char *, int, int, int);
-STATIC void expandmeta(struct strlist *, int);
+STATIC void expandmeta(struct strlist *);
 #ifdef HAVE_GLOB
 STATIC void addglob(const glob_t *);
 #else
@@ -205,7 +205,7 @@ expandarg(union node *arg, struct arglist *arglist, int flag)
 		ifsbreakup(p, -1, &exparg);
 		*exparg.lastp = NULL;
 		exparg.lastp = &exparg.list;
-		expandmeta(exparg.list, flag);
+		expandmeta(exparg.list);
 	} else {
 		sp = (struct strlist *)stalloc(sizeof (struct strlist));
 		sp->text = p;
@@ -1155,9 +1155,7 @@ out:
 
 #ifdef HAVE_GLOB
 STATIC void
-expandmeta(str, flag)
-	struct strlist *str;
-	int flag;
+expandmeta(struct strlist *str)
 {
 	/* TODO - EXP_REDIR */
 
@@ -1221,7 +1219,7 @@ STATIC unsigned expdir_max;
 
 
 STATIC void
-expandmeta(struct strlist *str, int flag)
+expandmeta(struct strlist *str)
 {
 	static const char metachars[] = {
 		'*', '?', '[', 0
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove unused expandmeta() flag parameter
  2020-04-29  6:29 [PATCH] Remove unused expandmeta() flag parameter Denys Vlasenko
@ 2020-05-15  6:30 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-05-15  6:30 UTC (permalink / raw)
  To: Denys Vlasenko; +Cc: dash

On Wed, Apr 29, 2020 at 08:29:53AM +0200, Denys Vlasenko wrote:
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> ---
>  src/expand.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-15  6:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29  6:29 [PATCH] Remove unused expandmeta() flag parameter Denys Vlasenko
2020-05-15  6:30 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).