From: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dash@vger.kernel.org, jer@gentoo.org, floppym@gentoo.org
Subject: Re: [PATCH] input: Fix compiling against libedit with -fno-common
Date: Fri, 15 May 2020 16:30:50 +1000 [thread overview]
Message-ID: <20200515063050.GA28740@gondor.apana.org.au> (raw)
In-Reply-To: <20200502183706.2719782-1-floppym@gentoo.org>
Mike Gilbert <floppym@gentoo.org> wrote:
> From: Jeroen Roovers <jer@gentoo.org>
>
> With -fno-common, which will be enabled by default in GCC 10, we see
> this error:
>
> ld: input.o:(.bss+0x0): multiple definition of `el';
> histedit.o:(.bss+0x8): first defined here
>
> To fix this, simply remove the definition as it is not needed.
>
> Signed-off-by: Jeroen Roovers <jer@gentoo.org>
> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> ---
> src/input.c | 4 ----
> 1 file changed, 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-05-15 6:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 18:37 [PATCH] input: Fix compiling against libedit with -fno-common Mike Gilbert
2020-05-15 6:30 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515063050.GA28740@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=floppym@gentoo.org \
--cc=jer@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).