dash.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fail if building --with-libedit and can't find libedit
@ 2020-12-23  0:46 C. McEnroe
  2021-01-13  6:22 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: C. McEnroe @ 2020-12-23  0:46 UTC (permalink / raw)
  To: dash; +Cc: C. McEnroe

Previously, configure --with-libedit would only fail in the case where
libedit is available but its header file histedit.h is not.
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 33f0b08..9d96f5a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -175,7 +175,8 @@ if test "$with_libedit" = "yes"; then
 	AC_CHECK_LIB(edit, history_init, [
 		AC_CHECK_HEADER([histedit.h], [use_libedit="yes"],
 				AC_MSG_ERROR(
-					[Can't find required header files.]))])
+					[Can't find required header files.]))], [
+		AC_MSG_ERROR([Can't find libedit.])])
 fi
 if test "$use_libedit" != "yes"; then
 	AC_DEFINE([SMALL], 1, [Define if you build with -DSMALL])
-- 
2.29.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fail if building --with-libedit and can't find libedit
  2020-12-23  0:46 [PATCH] Fail if building --with-libedit and can't find libedit C. McEnroe
@ 2021-01-13  6:22 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2021-01-13  6:22 UTC (permalink / raw)
  To: C. McEnroe; +Cc: dash

C. McEnroe <june@causal.agency> wrote:
> Previously, configure --with-libedit would only fail in the case where
> libedit is available but its header file histedit.h is not.
> ---
> configure.ac | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-13  6:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23  0:46 [PATCH] Fail if building --with-libedit and can't find libedit C. McEnroe
2021-01-13  6:22 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).