From: Herbert Xu <herbert@gondor.apana.org.au>
To: June Bug <june@causal.agency>
Cc: dash@vger.kernel.org
Subject: Re: [PATCH v2] Cache the expanded prompt for editline
Date: Fri, 15 Jan 2021 07:12:58 +1100 [thread overview]
Message-ID: <20210114201257.GA15898@gondor.apana.org.au> (raw)
In-Reply-To: <F9311B17-4FC9-4623-9512-8022D4B96BFB@causal.agency>
On Thu, Jan 14, 2021 at 10:43:21AM -0500, June Bug wrote:
>
> It seems unlikely given the lack of consistency of when libedit
> calls the prompt callback. I only noticed it was happening when I
> patched in support for EL_RPROMPT (right-aligned prompts), which
> when active causes libedit to call the prompt callback on *every*
> keypress. It seemed not to happen with only a regular prompt and
> it took some experimenting to notice typing backspaces causes it.
> The behaviour is completely undocumented in libedit.
>
> Anecdotally, typing at the prompt becomes painful when it is expanded
> over and over and does anything non-trivial, even just a command
> substitution that runs no external commands.
OK, in that case I think it's best to fix this in libedit instead.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-01-14 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 19:47 [PATCH] Cache the expanded prompt for editline C. McEnroe
2020-12-23 21:02 ` [PATCH v2] " C. McEnroe
2021-01-13 6:18 ` Herbert Xu
2021-01-14 15:43 ` June Bug
2021-01-14 20:12 ` Herbert Xu [this message]
2021-01-14 20:22 ` June Bug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114201257.GA15898@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=june@causal.agency \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).