From: Harald van Dijk <email@example.com> To: Herbert Xu <firstname.lastname@example.org>, email@example.com Cc: Stephane Chazelas <firstname.lastname@example.org>, Gioele Barabucci <email@example.com> Subject: Re: [PATCH v2] builtin: Fix handling of trailing IFS white spaces Date: Mon, 6 Jun 2016 22:43:39 +0200 [thread overview] Message-ID: <5755E07B.firstname.lastname@example.org> (raw) In-Reply-To: <20160606084805.GA20946@gondor.apana.org.au> On 06/06/16 10:48, Herbert Xu wrote: > On Fri, Dec 04, 2015 at 08:51:19PM +0100, Harald van Dijk wrote: >> >> Here it is. Attached is an updated patch that ignores the complete >> terminator if only a single field remains, otherwise ignores only >> trailing IFS whitespace. > > There is a little bug in the patch if you happened to start with > an escaped IFS, otherwise I think it's good. Thanks. If starting with an escaped IFS, the CTLESC should already have been skipped before the if (maxargs == 1) check gets executed. That's done at the start of the outer loop, but is not visible in the patch because it's unmodified from the original code. Or did I misunderstand you here? > However, I think this loop is getting too deep so I've reworked > it to have just one loop over the string instead of three (two > nested loops). > Please test this. With the link sent by Martijn Dekker earlier in this thread: <http://web.archive.org/web/20050414022354/http://www.research.att.com/~gsf/public/ifs.sh> it gives a lot of failures: # tests 6856 passed 1844 failed 5012 I'll look into it in more detail later, if no one beats me to it. Cheers, Harald van Dijk
next prev parent reply other threads:[~2016-06-06 20:44 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-02 22:37 dash: read does not ignore trailing spaces Gioele Barabucci 2015-12-02 23:25 ` Jilles Tjoelker 2015-12-03 21:02 ` Harald van Dijk 2015-12-03 21:17 ` Stephane Chazelas 2015-12-03 21:43 ` Martijn Dekker 2015-12-03 23:04 ` Stephane Chazelas 2015-12-03 23:17 ` Stephane Chazelas 2015-12-04 0:00 ` Stephane Chazelas 2015-12-03 22:26 ` Harald van Dijk 2015-12-04 19:51 ` Harald van Dijk 2016-01-29 12:57 ` Martijn Dekker 2016-06-06 8:48 ` [PATCH v2] builtin: Fix handling of trailing IFS white spaces Herbert Xu 2016-06-06 20:43 ` Harald van Dijk [this message] 2016-06-07 9:25 ` [PATCH v3] " Herbert Xu 2016-06-12 10:35 ` Harald van Dijk 2016-06-12 11:06 ` Herbert Xu 2016-06-12 11:12 ` Harald van Dijk 2016-06-12 12:17 ` [PATCH v4] " Herbert Xu 2016-06-19 22:01 ` Harald van Dijk 2016-06-20 1:28 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5755E07B.email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2] builtin: Fix handling of trailing IFS white spaces' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).