dash.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "solsTiCe d'Hiver" <solstice.dhiver@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: dash@vger.kernel.org
Subject: Re: "if [ s1 > s2 ]" broken, writing a s2 file
Date: Mon, 8 Dec 2014 18:46:03 +0100	[thread overview]
Message-ID: <CAE4vF2eOY_nAHKWeQTza2L48+19Z_hibK+BSd7sqodY9o=v5UQ@mail.gmail.com> (raw)
In-Reply-To: <5485E25D.9080100@redhat.com>

thank you to enlighten me on that. I just learned another thing today. ;-)

2014-12-08 18:39 GMT+01:00 Eric Blake <eblake@redhat.com>:
> On 12/08/2014 10:32 AM, solsTiCe d'Hiver wrote:
>> hello,
>> folowing that bug
>> https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1400357,
>> I follow through to investigate and I found out
>> that whatever I try, when comparing 2 strings I always end up with a
>> file written to disk
>>
>>>From the man page
>> test expression
>>      [ expression ]
>> [...]
>> s1 > s2       True if string s1 comes after s2 based on the ASCII
>> value of their characters.
>
> You HAVE to escape the > so that it is interpreted as an argument and
> not a redirection operator.  The bug is not in dash, but in your usage.
>
>>
>> when I try to use it:
>> a="ert"
>> b="aze"
>> if [ $a > $b ] ; then
>
> Wrong.  Use:
>
> if [ "$a" ">" "$b" ]; then
>
>
>>
>> so this "if syntax" is broken or I don't knwo how to use it.
>
> The latter.
>
>>
>> Also it is really dangerous  to use a syntax similar to file
>> redirection and this is exactly what is happening here.
>
> POSIX is proposing the addition of the shell builtin [[ ]], where
> because it is a syntactical part of the shell, it would have safe
> semantics (that is, [[ $a > $b ]] would be perfectly safe and do the
> right thing). But until the POSIX standardization is complete, dash does
> not implement [[; and as long as only '[' is portable (with its
> unfortunate but historically-mandated semantics of operating as if it
> were NOT a builtin, in that shell parsing happens before test sees its
> arguments), then you have to quote anything that might otherwise be
> misinterpreted during parsing.
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>

      reply	other threads:[~2014-12-08 17:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 17:32 "if [ s1 > s2 ]" broken, writing a s2 file solsTiCe d'Hiver
2014-12-08 17:39 ` Eric Blake
2014-12-08 17:46   ` solsTiCe d'Hiver [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE4vF2eOY_nAHKWeQTza2L48+19Z_hibK+BSd7sqodY9o=v5UQ@mail.gmail.com' \
    --to=solstice.dhiver@gmail.com \
    --cc=dash@vger.kernel.org \
    --cc=eblake@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).