From: Denys Vlasenko <vda.linux@googlemail.com>
To: Harald van Dijk <harald@gigawatt.nl>
Cc: DASH shell mailing list <dash@vger.kernel.org>
Subject: Re: $ENV handling depends on defined(linux), why??
Date: Wed, 13 Oct 2021 21:17:24 +0200 [thread overview]
Message-ID: <CAK1hOcM9mQnbsgGz47fYr+A059hr1SW++_25_cGCdVVFfnofUA@mail.gmail.com> (raw)
In-Reply-To: <61f9c77a-b8c9-d25d-c72d-34e342917f58@gigawatt.nl>
On Wed, Oct 13, 2021 at 11:56 AM Harald van Dijk <harald@gigawatt.nl> wrote:
> On 13/10/2021 10:39, Denys Vlasenko wrote:
> > Who in their right mind would have a *setuid*
> > shell executable on any system where security matters?
>
> I suspect this was originally not for the benefit of setuid shell
> executables, but setuid shell scripts. Linux does not support those, so
> the check is considered unnecessary on Linux.
>
> However, actually, doing something along those lines is useful even on
> Linux when setuid applications can be tricked to launch shell processes
> in insecure ways.
Not sourcing $ENV is nowhere near enough to ploug this hole,
so doing it is still pointless.
> bash implements "privileged mode" which drops shell
> privileges except when the setuid application specifically requests
> keeping them
*That* would solve the problem. The code I talk about does not
solve that problem.
I propose to delete entire #ifndef/#endif block.
next prev parent reply other threads:[~2021-10-13 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 9:39 $ENV handling depends on defined(linux), why?? Denys Vlasenko
2021-10-13 9:55 ` Harald van Dijk
2021-10-13 19:17 ` Denys Vlasenko [this message]
2021-10-13 21:31 ` Harald van Dijk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK1hOcM9mQnbsgGz47fYr+A059hr1SW++_25_cGCdVVFfnofUA@mail.gmail.com \
--to=vda.linux@googlemail.com \
--cc=dash@vger.kernel.org \
--cc=harald@gigawatt.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).