From: Harald van Dijk <harald@gigawatt.nl>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, dash@vger.kernel.org
Cc: Peter Korsgaard <jacmet@sunsite.dk>
Subject: Re: [PATCH] Don't include config.h when building helpers using the native compiler
Date: Mon, 22 Jun 2020 09:53:37 +0100 [thread overview]
Message-ID: <b26fe976-2937-3c0e-8543-e7360d03059b@gigawatt.nl> (raw)
In-Reply-To: <20200622052513.1850288-1-fontaine.fabrice@gmail.com>
On 22/06/2020 06:25, Fabrice Fontaine wrote:
> config.h contains settings for the cross compiler (most importantly
> 32/64bit versions of functions), so don't include it when calling the
> native compiler to build the helpers.
>
> Otherwise we get build errors like:
>
> /usr/bin/gcc -include ../config.h -DBSD=1 -DSHELL -DIFS_BROKEN -g -O2 -Wall -o mkinit mkinit.c
> In file included from /usr/include/sys/stat.h:107,
> from /usr/include/fcntl.h:38,
> from mkinit.c:50:
> /usr/include/bits/stat.h:117: error: redefinition of ‘struct stat’
> In file included from /usr/include/fcntl.h:38,
> from mkinit.c:50:
> /usr/include/sys/stat.h:504: error: redefinition of ‘stat’
> /usr/include/sys/stat.h:455: note: previous definition of ‘stat’ was here
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> [Retrieved from:
> https://git.buildroot.net/buildroot/tree/package/dash/0001-no-config.h-for-helpers.patch]
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
A better version of this patch has already been submitted and accepted
in 2018: <https://www.spinics.net/lists/dash/msg01629.html>.
Cheers,
Harald van Dijk
next prev parent reply other threads:[~2020-06-22 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 5:25 [PATCH] Don't include config.h when building helpers using the native compiler Fabrice Fontaine
2020-06-22 7:42 ` Herbert Xu
2020-06-22 8:53 ` Harald van Dijk [this message]
2020-06-22 10:44 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b26fe976-2937-3c0e-8543-e7360d03059b@gigawatt.nl \
--to=harald@gigawatt.nl \
--cc=dash@vger.kernel.org \
--cc=fontaine.fabrice@gmail.com \
--cc=jacmet@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).