From: Harald van Dijk <harald@gigawatt.nl>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: DASH shell mailing list <dash@vger.kernel.org>
Subject: Re: [v2 PATCH] redir: Clear saved redirections in subshell
Date: Fri, 17 Jan 2020 23:11:29 +0000 [thread overview]
Message-ID: <dcff517b-8cb8-2be0-cd18-8b2679e03d75@gigawatt.nl> (raw)
In-Reply-To: <20200117152825.ll4kge4ehy36xhxw@gondor.apana.org.au>
On 17/01/2020 15:28, Herbert Xu wrote:
> On Fri, Jan 17, 2020 at 05:57:55PM +0800, Herbert Xu wrote:
>>
>> Something like this should fix the redir problem. I'll address the
>> other issue in a subsequent patch.
>
> Here is a new version that adds a forkreset hook to mkinit so
> that we do the clearing even when we enter a subshell without
> forking.
Yup, that's something I've had for a while for the same reason. I called
it envreset since it's not only called after forking, but it's the same
thing.
The clearing of redirlist is also what I ended up doing, except I did
free the memory by adding a drop parameter to unwindredir and passing
that on to popredir. That should not affect the user-visible behaviour.
Cheers,
Harald van Dijk
next prev parent reply other threads:[~2020-01-17 23:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c1a9c062-0917-d3f3-8826-811b5a4fd802@gigawatt.nl>
2020-01-17 8:51 ` EXIT trap handling in subshells broken Herbert Xu
2020-01-17 9:57 ` [PATCH] redir: Clear saved redirections in subshell Herbert Xu
2020-01-17 15:28 ` [v2 PATCH] " Herbert Xu
2020-01-17 23:11 ` Harald van Dijk [this message]
2020-01-19 10:21 ` [v3 " Herbert Xu
2020-01-17 10:15 ` EXIT trap handling in subshells broken Herbert Xu
2020-01-17 22:58 ` Harald van Dijk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcff517b-8cb8-2be0-cd18-8b2679e03d75@gigawatt.nl \
--to=harald@gigawatt.nl \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).