dash.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roy <roytam@gmail.com>
To: dash@vger.kernel.org
Subject: [PATCH] printf: use %ll instead of %j
Date: Mon, 03 Dec 2012 15:42:37 +0800	[thread overview]
Message-ID: <op.woqc1kj2dyj81a@2fprep> (raw)

MSYS libc does not support %j[dXx] format, only %ll[dXx] is supported.

diff --git a/src/bltin/printf.c b/src/bltin/printf.c
index 893295c..12ce660 100644
--- a/src/bltin/printf.c
+++ b/src/bltin/printf.c
@@ -319,11 +319,12 @@ mklong(const char *str, const char *ch)
         char *copy;
         size_t len;

-       len = ch - str + 3;
+       len = ch - str + 4;
         STARTSTACKSTR(copy);
         copy = makestrspace(len, copy);
-       memcpy(copy, str, len - 3);
-       copy[len - 3] = 'j';
+       memcpy(copy, str, len - 4);
+       copy[len - 4] = 'l';
+       copy[len - 3] = 'l';
         copy[len - 2] = *ch;
         copy[len - 1] = '\0';
         return (copy);


             reply	other threads:[~2012-12-03  7:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03  7:42 Roy [this message]
2012-12-03 14:32 ` [PATCH] printf: use %ll instead of %j Jonathan Nieder
     [not found] ` <50BCDA80.8000705@gigawatt.nl>
2012-12-03 17:58   ` Harald van Dijk
2012-12-04  6:38     ` Jonathan Nieder
2013-08-23 10:30       ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.woqc1kj2dyj81a@2fprep \
    --to=roytam@gmail.com \
    --cc=dash@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).