From: Will Abele <will.abele@starlab.io>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Will Abele <will.abele@starlab.io>
Subject: [Xen-devel] [PATCH 1/1] xen/arm: Use "" instead of "/" for domU root node.
Date: Sat, 6 Jul 2019 18:02:48 +0000 [thread overview]
Message-ID: <dbab1e7ad690f326e2ae230d2dbb2bb80bcfeace.1562435004.git.will.abele@starlab.io> (raw)
In-Reply-To: <cover.1562435004.git.will.abele@starlab.io>
From: Will Abele <will.abele@starlab.io>
Prior to linux a7e4cfb0a7ca4773e7d0dd1d9c018ab27a15360e
(merged in 4.15), Linux checked to see if the device tree version was
greater than 0x10 by checking for a root node "/". Xen creates a version
0x11 device tree, so the root node's unit name should be "".
Signed-off-by: Will Abele <will.abele@starlab.io>
---
xen/arch/arm/domain_build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index d9836779d1..af936b4c3a 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1697,7 +1697,7 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo)
if ( ret < 0 )
goto err;
- ret = fdt_begin_node(kinfo->fdt, "/");
+ ret = fdt_begin_node(kinfo->fdt, "");
if ( ret < 0 )
goto err;
--
2.20.1 (Apple Git-117)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-06 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 18:02 [Xen-devel] [PATCH 0/1] Dom0less guest device tree format Will Abele
2019-07-06 18:02 ` Will Abele [this message]
2019-07-06 18:17 ` Julien Grall
2019-07-06 18:19 ` Julien Grall
2019-07-06 21:10 ` Will Abele
2019-07-08 7:39 ` Viktor Mitin
2019-07-08 15:18 ` Julien Grall
2019-07-08 18:27 ` Will Abele
2019-07-08 22:28 ` Stefano Stabellini
2019-07-09 13:17 ` Will Abele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbab1e7ad690f326e2ae230d2dbb2bb80bcfeace.1562435004.git.will.abele@starlab.io \
--to=will.abele@starlab.io \
--cc=Volodymyr_Babchuk@epam.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.