All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jane Chu <jane.chu@oracle.com>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"Du, Fan" <fan.du@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bp@suse.de" <bp@suse.de>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"tiwai@suse.de" <tiwai@suse.de>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"jglisse@redhat.com" <jglisse@redhat.com>,
	"zwisler@kernel.org" <zwisler@kernel.org>,
	"mhocko@suse.com" <mhocko@suse.com>,
	"baiyaowei@cmss.chinamobile.com" <baiyaowei@cmss.chinamobile.com>,
	"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
	"Wu, Fengguang" <fengguang.wu@intel.com>,
	"Huang, Ying" <ying.huang@intel.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM
Date: Fri, 25 Jan 2019 11:10:22 -0800	[thread overview]
Message-ID: <dc7d8190-2c94-9bdb-fb5b-a80a3fb55822@oracle.com> (raw)
In-Reply-To: <b7d45d83a314955e7dff25401dfc0d4f4247cfcd.camel@intel.com>


On 1/25/2019 10:20 AM, Verma, Vishal L wrote:
> 
> On Fri, 2019-01-25 at 09:18 -0800, Dan Williams wrote:
>> On Fri, Jan 25, 2019 at 12:20 AM Du, Fan <fan.du@intel.com> wrote:
>>> Dan
>>>
>>> Thanks for the insights!
>>>
>>> Can I say, the UCE is delivered from h/w to OS in a single way in
>>> case of machine
>>> check, only PMEM/DAX stuff filter out UC address and managed in its
>>> own way by
>>> badblocks, if PMEM/DAX doesn't do so, then common RAS workflow will
>>> kick in,
>>> right?
>>
>> The common RAS workflow always kicks in, it's just the page state
>> presented by a DAX mapping needs distinct handling. Once it is
>> hot-plugged it no longer needs to be treated differently than "System
>> RAM".
>>
>>> And how about when ARS is involved but no machine check fired for
>>> the function
>>> of this patchset?
>>
>> The hotplug effectively disconnects this address range from the ARS
>> results. They will still be reported in the libnvdimm "region" level
>> badblocks instance, but there's no safe / coordinated way to go clear
>> those errors without additional kernel enabling. There is no "clear
>> error" semantic for "System RAM".
>>
> Perhaps as future enabling, the kernel can go perform "clear error" for
> offlined pages, and make them usable again. But I'm not sure how
> prepared mm is to re-accept pages previously offlined.
> 

Offlining a DRAM backed page due to an UC makes sense because
  a. the physical DRAM cell might still have an error
  b. power cycle, scrubing could potentially 'repair' the DRAM cell,
making the page usable again.

But for a PMEM backed page, neither is true. If a poison bit is set in
a page, that indicates the underlying hardware has completed the repair 
work, all that's left is for software to recover.  Secondly, because 
poison is persistent, unless software explicitly clear the bit,
the page is permanently unusable.

thanks,
-jane

  reply	other threads:[~2019-01-25 19:10 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-24 23:14 [PATCH 0/5] [v4] Allow persistent memory to be used like normal RAM Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-24 23:14 ` [PATCH 1/5] mm/resource: return real error codes from walk failures Dave Hansen
2019-01-24 23:14   ` Dave Hansen
2019-01-24 23:14   ` Dave Hansen
     [not found]   ` <20190124231442.EFD29EE0-LXbPSdftPKxrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2019-01-25 21:02     ` Bjorn Helgaas
2019-01-25 21:02       ` Bjorn Helgaas
2019-01-25 21:02       ` Bjorn Helgaas
2019-01-25 21:09       ` Dave Hansen
2019-01-25 21:09         ` Dave Hansen
2019-01-25 21:19         ` Bjorn Helgaas
2019-01-25 21:19           ` Bjorn Helgaas
     [not found]         ` <4898e064-5298-6a82-83ea-23d16f3dfb3d-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-01-29  1:18           ` Michael Ellerman
2019-01-29  1:18             ` Michael Ellerman
2019-01-24 23:14 ` [PATCH 2/5] mm/resource: move HMM pr_debug() deeper into resource code Dave Hansen
2019-01-24 23:14   ` Dave Hansen
2019-01-24 23:14   ` Dave Hansen
2019-01-25 19:07   ` Jerome Glisse
2019-01-25 19:07     ` Jerome Glisse
2019-01-25 21:18   ` Bjorn Helgaas
2019-01-25 21:18     ` Bjorn Helgaas
2019-01-25 21:18     ` Bjorn Helgaas
2019-01-25 21:24     ` Dave Hansen
2019-01-25 21:24       ` Dave Hansen
2019-01-29  1:34       ` Michael Ellerman
2019-01-29  1:34         ` Michael Ellerman
2019-01-24 23:14 ` [PATCH 3/5] mm/memory-hotplug: allow memory resources to be children Dave Hansen
2019-01-24 23:14   ` Dave Hansen
2019-01-24 23:14   ` Dave Hansen
2019-01-24 23:14 ` [PATCH 4/5] dax/kmem: let walk_system_ram_range() search child resources Dave Hansen
2019-01-24 23:14   ` Dave Hansen
2019-01-24 23:14   ` Dave Hansen
2019-01-24 23:14 ` [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM Dave Hansen
2019-01-24 23:14   ` Dave Hansen
2019-01-24 23:14   ` Dave Hansen
2019-01-25  6:13   ` Jane Chu
2019-01-25  6:13     ` Jane Chu
2019-01-25  6:27     ` Dan Williams
2019-01-25  6:27       ` Dan Williams
2019-01-25  8:20       ` Du, Fan
2019-01-25  8:20         ` Du, Fan
2019-01-25 17:18         ` Dan Williams
2019-01-25 18:20           ` Verma, Vishal L
2019-01-25 18:20             ` Verma, Vishal L
2019-01-25 19:10             ` Jane Chu [this message]
2019-01-25 19:15               ` Dan Williams
2019-01-25 19:15                 ` Dan Williams
2019-01-25 19:15                 ` Dan Williams
2019-01-25 23:30                 ` Jane Chu
2019-01-28  9:25                 ` Michal Hocko
2019-01-28 16:34                   ` Dan Williams
2019-01-28 16:34                     ` Dan Williams
2019-01-28 16:34                     ` Dan Williams
2019-02-09 11:00   ` Brice Goglin
2019-02-11 16:22     ` Dave Hansen
2019-02-11 16:22       ` Dave Hansen
2019-02-12 19:59       ` Brice Goglin
2019-02-13  0:30         ` Dan Williams
2019-02-13  0:30           ` Dan Williams
2019-02-13  8:12           ` Brice Goglin
2019-02-13  8:12             ` Brice Goglin
2019-02-13  8:24             ` Dan Williams
2019-02-13  8:24               ` Dan Williams
2019-02-13  8:43               ` Brice Goglin
2019-02-13  8:43                 ` Brice Goglin
2019-02-13 13:06                 ` Brice Goglin
2019-02-13 13:06                   ` Brice Goglin
2019-02-13 16:19                   ` Dan Williams
2019-02-13 16:19                     ` Dan Williams
2019-01-25 19:08 ` [PATCH 0/5] [v4] Allow persistent memory to be used " Jerome Glisse
2019-01-25 19:08   ` Jerome Glisse
2019-01-28 11:09 ` Balbir Singh
2019-01-28 11:09   ` Balbir Singh
2019-01-28 16:50   ` Dave Hansen
2019-01-28 16:50     ` Dave Hansen
2019-01-28 16:50     ` Dave Hansen
2019-02-25 18:57 [PATCH 0/5] [v5] " Dave Hansen
2019-02-25 18:57 ` [PATCH 5/5] dax: "Hotplug" persistent memory for use " Dave Hansen
2019-02-25 18:57   ` Dave Hansen
2019-02-25 18:57   ` Dave Hansen
2019-02-25 22:56   ` Verma, Vishal L
2019-02-25 22:56     ` Verma, Vishal L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc7d8190-2c94-9bdb-fb5b-a80a3fb55822@oracle.com \
    --to=jane.chu@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baiyaowei@cmss.chinamobile.com \
    --cc=bhelgaas@google.com \
    --cc=bp@suse.de \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=fan.du@intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=jglisse@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mhocko@suse.com \
    --cc=thomas.lendacky@amd.com \
    --cc=tiwai@suse.de \
    --cc=vishal.l.verma@intel.com \
    --cc=ying.huang@intel.com \
    --cc=zwisler@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.