All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominic Chen <d.c.ddcc@gmail.com>
To: Wu Hao <hao.wu@intel.com>
Cc: mdf@kernel.org, linux-fpga@vger.kernel.org
Subject: Re: [PATCH v3] fpga: dfl: afu: support debug access to memory-mapped afu regions
Date: Mon, 9 Mar 2020 14:53:05 -0400	[thread overview]
Message-ID: <dca2ed7b-ff6e-2886-238b-6a924553b9f1@gmail.com> (raw)
In-Reply-To: <20200309072810.GA852@hao-dev>


On 3/9/2020 3:28 AM, Wu Hao wrote:
> On Wed, Mar 04, 2020 at 10:33:10PM -0500, Dominic Chen wrote:
>> +static const struct vm_operations_struct afu_vma_ops = {
>> +#ifdef CONFIG_HAVE_IOREMAP_PROT
>> +	.access = generic_access_phys,
>> +#endif /* CONFIG_HAVE_IOREMAP_PROT */
> To me, it's very clear for #ifdef - #end. So looks like this
> /* CONFIG_HAVE_IOREMAP_PROT */ comments is not needed.
>
> Could you please remove it? 
>
> Then
>
> Acked-by: Wu Hao <hao.wu@intel.com>
>
> Thanks
> Hao

Thanks, sent out v4.

Dominic

  reply	other threads:[~2020-03-09 18:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05  3:33 [PATCH v3] fpga: dfl: afu: support debug access to memory-mapped afu regions Dominic Chen
2020-03-09  7:28 ` Wu Hao
2020-03-09 18:53   ` Dominic Chen [this message]
2020-03-21 20:15 ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dca2ed7b-ff6e-2886-238b-6a924553b9f1@gmail.com \
    --to=d.c.ddcc@gmail.com \
    --cc=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=mdf@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.